Constant DC verification #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJoskiy
force-pushed
the
DC-verification
branch
2 times, most recently
from
cee6cc2 to
02b27b6
Compare
xJoskiy
force-pushed
the
DC-verification
branch
from
02b27b6 to
5e7dbbc
Compare
xJoskiy
force-pushed
the
DC-verification
branch
2 times, most recently
from
ebd4eae to
deaa199
Compare
xJoskiy
force-pushed
the
DC-verification
branch
3 times, most recently
from
a90e568 to
3d0b351
Compare
xJoskiy
force-pushed
the
DC-verification
branch
5 times, most recently
from
ce333d9 to
9e2a146
Compare
Now it is possible to pass an option that tells the algorithm whether to collect violations or not.
xJoskiy
force-pushed
the
DC-verification
branch
from
9e2a146 to
f805864
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| std::string ToString() const { | ||
| std::ostringstream ss; | ||
| static char constexpr const open[]{'(', '['}; |
There was a problem hiding this comment.
warning: invalid case style for static constant 'open' [readability-identifier-naming]
Suggested change
| static char constexpr const open[]{'(', '['}; | |
| static char constexpr const kOpen[]{'(', '['}; |
src/core/util/kdtree.h:80:
- ss << open[lower_bound_type_[i]] << lower_bound_[i].ToString() << ", ";
+ ss << kOpen[lower_bound_type_[i]] << lower_bound_[i].ToString() << ", ";| std::string ToString() const { | ||
| std::ostringstream ss; | ||
| static char constexpr const open[]{'(', '['}; | ||
| static char constexpr const closed[]{')', ']'}; |
There was a problem hiding this comment.
warning: invalid case style for static constant 'closed' [readability-identifier-naming]
Suggested change
| static char constexpr const closed[]{')', ']'}; | |
| static char constexpr const kClosed[]{')', ']'}; |
src/core/util/kdtree.h:81:
- ss << upper_bound_[i].ToString() << closed[upper_bound_type_[i]] << '\n';
+ ss << upper_bound_[i].ToString() << kClosed[upper_bound_type_[i]] << '\n';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DC verification with constant predicactes, add violations highlights and minimization algorithm