Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 39 support #323

Merged
merged 4 commits into from
Jan 29, 2025
Merged

python 39 support #323

merged 4 commits into from
Jan 29, 2025

Conversation

hboisgon
Copy link
Contributor

@hboisgon hboisgon commented Jan 22, 2025

Issue addressed

Fixes #322
See also: conda-forge/hydromt_wflow-feedstock#21

Explanation

Fix and small release to fix support for python 3.9. Will be dropped again when moving to hydromt v1 / wflow v1

in the end, decided to drop support already to avoid additional testing for python 39

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@hboisgon
Copy link
Contributor Author

@savente93 can you help me with the failing py3.9 test? It fails as no cache is found and I have no idea how to fix it.
If this is too much work then we can prematurely drop python 3.9 support but I would like to do a minor release (0.7.1) and I'm not sure what would a number be if python 3.9 is officially dropped?

@savente93
Copy link

I'll have a look when I get to work and see if I can fix it. If it's just about a cache in the workflow it should be fairly easy. is this urgent?

@hboisgon hboisgon changed the title python 39 support and test python 39 support Jan 23, 2025
@hboisgon
Copy link
Contributor Author

After some discusssions with @savente93, decided to just drop support for python 39 already as it probably was not working for a while anyhow so no need for a major release.

@hboisgon hboisgon requested a review from savente93 January 23, 2025 02:13
@hboisgon
Copy link
Contributor Author

I'm still waiting to see if PR #320 can be part of the release. Once I know, I'll create the release tag. Could you already review @savente93 to see if I added all that is needed to upgrade to python 310? Thanks :)

Copy link

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, although I will say that if you're dopping support for python 3.9 then you can actually keep the X | Y instead of Union[X,Y] and X | None instead of Optional[X] since those syntaxes were added in python 3.10 and I think it looks nicer. At least it doesn't require you to import the Union and Optional types. Though of course it is still valid, so if you preferer it that way you can keep the PR as is. I'll leave that up to you :)

@hboisgon hboisgon merged commit fdefeb0 into main Jan 29, 2025
8 checks passed
@hboisgon hboisgon deleted the python39_releasefix branch January 29, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for python 3.9
2 participants