Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor topology navigation #1208

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

wkramer
Copy link
Collaborator

@wkramer wkramer commented Feb 13, 2025

Pull Request Template

Description

Please provide a brief description of the changes made in this pull request.

Screenshots (if applicable)

If there are any visual changes, please attach screenshots here.

Link to documentation (if applicable)

Add link to public Github pages (only documentation about configuration)

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

Copy link
Collaborator

@hvangeffen hvangeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks location search control text:
image

Change:

selectedLocationIds
? selectedLocation?.locationName
: 'Search locations'

To:

selectedLocation?.locationName ?? 'Search locations' 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants