Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peilbeheerst oktober #244

Merged
merged 91 commits into from
Feb 6, 2025
Merged

Peilbeheerst oktober #244

merged 91 commits into from
Feb 6, 2025

Conversation

rbruijnshkv
Copy link
Collaborator

Mainly worked on the parametrization of the water authorities.

@rbruijnshkv
Convert the crossings_to_ribasim notebook to version 2024.11
fb73a84
@rbruijnshkv
Convert the crossings_to_ribasim.py from Ribasim version 2024.10 to 2…
ae25ec2 
…024.11
@rbruijnshkv
Simplified the python file and made it Ribasim 2024.11 compatible
edf7de1
@rbruijnshkv
Ribasim 2024.11 compatible
c069b1a
@rbruijnshkv
Ribasim 2024.11 compatible, including improved outlet and pump control
c2912ff
@rbruijnshkv
New settings for Outlet and Pump Control, 2024.11 compatible
8818b01
@rbruijnshkv
Run pixi
7e32b75
@rbruijnshkv
Make 2024.11 compatible
a8c4307
@rbruijnshkv
Add AGV specific LevelBoundaries and metadata
5452290
@rbruijnshkv
Increase outlet and pump capacities
92fab3c 
Currently most of the sturing remains the same for each water authority. But this may change in the short future.
@rbruijnshkv
Add more output layers
62ee516
@rbruijnshkv
Make 2024.11 compatible
763d0bb
@rbruijnshkv
fix: correct pump function assignment logic
91b2314
@rbruijnshkv
Add notebooks for the parametrization of the other water authorities
7dab099
@rbruijnshkv
Create new Wetterskip model
1fdcea6
@rbruijnshkv
Add Noorderzijlvest
7ccfb0a
@rbruijnshkv
Add sturing
d23ce3c
@rbruijnshkv
Parametrize the peilbeheerste water authorities
94f8e9c
@rbruijnshkv
Add .json file for connector node control
8200c9d
@rbruijnshkv
Add meta_categorie
2bc85f2
@rbruijnshkv
Parametrize Zuiderzeeland
276bf7d
@rbruijnshkv
Delete and copy new qlr to avoid permission issues
de9f465
@rbruijnshkv
First steps to add relevant names (pilot)
fb1300b
@rbruijnshkv
Update .gitignore
8bd6a33
@rbruijnshkv
Bug fix + update target level + function pump
e93a7f4
@rbruijnshkv
Update ribasim_parametrization.py
07c9c3c
@rbruijnshkv
Create new shortest path for Wetterskip
657f365
@rbruijnshkv
Waterafvoer fixes HHNK
62d619f
@rbruijnshkv
Remove temp fix
55430b3
@rbruijnshkv rbruijnshkv requested a review from visr January 29, 2025 16:42
visr
visr requested changes Feb 3, 2025
View reviewed changes
src/peilbeheerst_model/peilbeheerst_model/controle_output.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/controle_output.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/crossings_to_ribasim.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/crossings_to_ribasim.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/crossings_to_ribasim.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/ribasim_feedback_processor.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/ribasim_parametrization.py Outdated Show resolved Hide resolved
src/peilbeheerst_model/peilbeheerst_model/ribasim_parametrization.py Outdated Show resolved Hide resolved
@visr
Copy link
Member

visr commented Feb 3, 2025

Can you convert all notebooks to scripts like #171?

What is import load_ribasim # noqa: F401

And remove

%reload_ext autoreload
%autoreload 2
warnings.filterwarnings("ignore")

@visr
Copy link
Member

visr commented Feb 3, 2025

There are also 63 occurances of /DATAFOLDER/. For thegoodcloud we are using RIBASIM_NL_DATA_DIR. Although perhaps that should be addressed in a separate issue, I don't want to hold this up longer than needed.

@rbruijnshkv rbruijnshkv self-assigned this Feb 4, 2025
@visr visr mentioned this pull request Feb 4, 2025
Closed
@rbruijnshkv
Copy link
Collaborator Author

The requested changes have been addressed as far as I know. @visr, can you review it again?

If I’ve missed anything or if there are areas for improvement, please let me know!

@visr visr mentioned this pull request Feb 6, 2025
Open
@visr visr merged commit 9039b05 into main Feb 6, 2025
4 checks passed
@visr visr deleted the peilbeheerst_oktober branch February 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees

@rbruijnshkv rbruijnshkv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbruijnshkv @visr