Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Made InfraPriorityStrategy default for KoswatSummaryBuilder #214

Merged
merged 5 commits into from
Nov 5, 2024
Merged

chore: Made InfraPriorityStrategy default for KoswatSummaryBuilder #214

merged 5 commits into from
Nov 5, 2024

Conversation

Carsopre
Copy link
Collaborator

@Carsopre Carsopre commented Nov 1, 2024 •
edited
Loading

Issue addressed

Solves #192

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the KOSWAT team.

What has been done?

  • Changed default_factory value for KoswatSummaryBuilder.strategy_type to InfraPriorityStrategy.
  • Updated documentation according to Update documentation #193

Checklist

  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

It is expected that the test bench will run considerably slower after these modifications.

@Carsopre Carsopre linked an issue Nov 1, 2024 that may be closed by this pull request
Base strategy on different order #196
Open
ArdtK
ArdtK approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@ArdtK ArdtK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is linked to the right issue. Shouldn't that be #192?

docs/reference/koswat_strategies.md Outdated Show resolved Hide resolved
@Carsopre Carsopre removed a link to an issue Nov 5, 2024
Base strategy on different order #196
Open
@Carsopre Carsopre linked an issue Nov 5, 2024 that may be closed by this pull request
Make the new strategy default one. #192
Closed
@Carsopre Carsopre merged commit 19c3834 into master Nov 5, 2024
@Carsopre Carsopre deleted the feat/196-base-strategy-on-different-order branch November 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArdtK ArdtK ArdtK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the new strategy default one.
2 participants
@Carsopre @ArdtK