-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/wrong stress stuff #43
Open
EleniSmyrniou
wants to merge
18
commits into
master
Choose a base branch
from
bugfix/wrong-stress-stuff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the absolute of the depth is not relevant
…bugfix/wrong-stress-stuff
…bugfix/wrong-stress-stuff # Conflicts: # tests/robertson_cpt_interpretation/test_robertson_cpt_interpretation.py
…bugfix/wrong-stress-stuff # Conflicts: # tests/robertson_cpt_interpretation/test_robertson_cpt_interpretation.py
|
bramvandeneijnden
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct changes to pore water pressure and calculation of Qtn and Fr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following for the norm calc:
Tests for n_method=True and n_method=False:
In the first test, we set n_method=True so that the stress exponent is forced to 0.5. We then compute the expected normalized tip resistance (Qtn) and friction ratio (Fr) using the same formulas and verify that the output arrays match our expectations (taking into account the clamping).
In the second test, we let the iterative procedure compute n (which for these inputs converges to 1.0). The expected values for Qtn and Fr are then computed using the resulting n.
Added the following unit tests for the effective stresses:
test_stress_calc_no_pwp_effect
test_stress_calc_positive_pwp
test_stress_calc_negative_pwp_clipped
test_stress_calc_negative_effective_clipped