Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasper Vault: Add support for Bitlayer network #2315

Closed
wants to merge 5 commits into from

Conversation

gaawai-l
Copy link
Contributor

Changes Made

  • Added Bitlayer network support

Questions and Feedback Requested

During the testing phase, I encountered an issue related to the display of volume data in our test scripts. Although the balance calculations appear accurate, the volume outputs for the Bitlayer network show as zero, which contradicts the visible data in the log outputs. Here is the relevant portion of the test script output:

Balances {
chain: 'arbitrum',
timestamp: undefined,
_balances: {
'arbitrum:0xfd086bc7cd5c481dcc9c85ebe478a1c0b69fcbb9': '4861199553528'
}
}
Balances {
chain: 'arbitrum',
timestamp: undefined,
_balances: {
'arbitrum:0xfd086bc7cd5c481dcc9c85ebe478a1c0b69fcbb9': '10918778574',
'arbitrum:0x050c24dbf1eec17babe5fc585f06116a259cc77a': '3216868',
'arbitrum:0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee': '7976569302325821',
'arbitrum:0x2f2a2543b76a4166549f7aab2e75bef0aefc5b0f': '4295'
}
}
Balances {
chain: 'base',
timestamp: undefined,
_balances: { 'base:0x833589fcd6edb6e08f4c7c32d4f71b54bda02913': '74130843372' }
}
Balances {
chain: 'base',
timestamp: undefined,
_balances: {
'base:0xcbb7c0000ab88b473b1f5afd9ef808440eed33bf': '131280',
'base:0x833589fcd6edb6e08f4c7c32d4f71b54bda02913': '57311004'
}
}
Balances {
chain: 'bitlayer',
timestamp: undefined,
_balances: {
'bitlayer:0xfe9f969faf8ad72a83b761138bf25de87eff9dd2': '2030061788014'
}
}
Balances {
chain: 'bitlayer',
timestamp: undefined,
_balances: {
'bitlayer:0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee': '27344127928410930',
'bitlayer:0xfe9f969faf8ad72a83b761138bf25de87eff9dd2': '3404500450'
}
}
ARBITRUM 👇
Backfill start time: 8/5/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 4.86 M
Daily premium volume: 14.03 k
End timestamp: 1736867209 (2025-01-14T15:06:49.000Z)

BASE 👇
Backfill start time: 7/8/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 74.13 k
Daily premium volume: 183
End timestamp: 1736867209 (2025-01-14T15:06:49.000Z)

BITLAYER 👇
Backfill start time: 7/8/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 0
Daily premium volume: 0
End timestamp: 1736867209 (2025-01-14T15:06:49.000Z)


I am unsure if this is due to:
- An issue with how the BITLAYER volume is being calculated within the test scripts.
- Incorrect or outdated network data.

I would appreciate any insights or suggestions from the team on how to resolve this problem.

Thank you for reviewing this pull request. I look forward to your feedback and any further discussions on the integration of the Bitlayer network.

@llamabutler
Copy link

The jaspervault adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts options jaspervault

🦙 Running JASPERVAULT adapter 🦙
---------------------------------------------------
Start Date:	Mon, 13 Jan 2025 15:34:13 GMT
End Date:	Tue, 14 Jan 2025 15:34:13 GMT
---------------------------------------------------

ARBITRUM 👇
Backfill start time: 8/5/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 4.96 M
Daily premium volume: 14.63 k
End timestamp: 1736868852 (2025-01-14T15:34:12.000Z)


BASE 👇
Backfill start time: 7/8/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 64.90 k
Daily premium volume: 164
End timestamp: 1736868852 (2025-01-14T15:34:12.000Z)


BITLAYER 👇
Backfill start time: 7/8/2024
NO METHODOLOGY SPECIFIED
Daily notional volume: 0
Daily premium volume: 0
End timestamp: 1736868852 (2025-01-14T15:34:12.000Z)

@g1nt0ki
Copy link
Member

g1nt0ki commented Jan 14, 2025

thanks, refactored and merged here: #2318

@g1nt0ki g1nt0ki closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants