Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix unicode compatibility #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix unicode compatibility #30

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a8aa66
Bugfix unicode compatibility
wradstok Jul 20, 2020
20c37cd
Fix indentation mistake
wradstok Jul 20, 2020
325bee0
Fix root cause of trailing space key issue
wradstok Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions codes/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import logging
import os
import random
import unicodedata

import numpy as np
import torch
Expand Down Expand Up @@ -123,7 +124,7 @@ def read_triple(file_path, entity2id, relation2id):
triples = []
with open(file_path) as fin:
for line in fin:
h, r, t = line.strip().split('\t')
h, r, t = map(lambda x: x.strip(), unicodedata.normalize('NFKC', line).split('\t'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str.strip could be a shorter replacement for lambda x: x.strip()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't realize this was possible.

triples.append((entity2id[h], relation2id[r], entity2id[t]))
return triples

Expand Down Expand Up @@ -160,12 +161,12 @@ def log_metrics(mode, step, metrics):

def main(args):
if (not args.do_train) and (not args.do_valid) and (not args.do_test):
raise ValueError('one of train/val/test mode must be choosed.')
raise ValueError('one of train/val/test mode must be chosen.')

if args.init_checkpoint:
override_config(args)
elif args.data_path is None:
raise ValueError('one of init_checkpoint/data_path must be choosed.')
raise ValueError('one of init_checkpoint/data_path must be chosen.')

if args.do_train and args.save_path is None:
raise ValueError('Where do you want to save your trained model?')
Expand All @@ -179,13 +180,13 @@ def main(args):
with open(os.path.join(args.data_path, 'entities.dict')) as fin:
entity2id = dict()
for line in fin:
eid, entity = line.strip().split('\t')
eid, entity = map(lambda x: x.strip(), unicodedata.normalize('NFKC', line).split('\t'))
entity2id[entity] = int(eid)

with open(os.path.join(args.data_path, 'relations.dict')) as fin:
relation2id = dict()
for line in fin:
rid, relation = line.strip().split('\t')
rid, relation = map(lambda x: x.strip(), unicodedata.normalize('NFKC', line).split('\t'))
relation2id[relation] = int(rid)

# Read regions for Countries S* datasets
Expand Down