Data Driving #25
Merged
Data Driving #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximumpower55
approved these changes
Apr 13, 2023
src/main/java/io/github/debuggyteam/architecture_extensions/api/BlockType.java
Show resolved
Hide resolved
| //ArchitectureExtensions.LOGGER.info("Deferred generation: "+deferral.modId()+" requested "+deferral.getIds()+" and registration was deferred."); | ||
| deferrals.put(groupedBlock.id(), deferral); | ||
| } else { | ||
| //ArchitectureExtensions.LOGGER.info("Deferred generation: "+deferral.modId()+" requested "+deferral.getIds()+" and registration was completed immediately."); |
There was a problem hiding this comment.
Why are these commented out code lines still here
There was a problem hiding this comment.
I wanted to help future debuggers
src/main/java/io/github/debuggyteam/architecture_extensions/DeferredRegistration.java
Show resolved
Hide resolved
woodiertexas
approved these changes
Apr 13, 2023
src/main/java/io/github/debuggyteam/architecture_extensions/ArchitectureExtensions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/debuggyteam/architecture_extensions/staticdata/StaticData.java
Show resolved
Hide resolved
|
Also regarding namespaces, it can potentially confuse someone if an arch-ex block made from "Example Mod" had |
src/main/java/io/github/debuggyteam/architecture_extensions/ArchitectureExtensions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables loader-agnostic mod integrations, but comes with some other changes:
This will take some careful documentation so people can get the most out of it, but in my opinion is a slam-dunk solution for #13