[datadog_dashboard] Handles cell_display_mode_options in Query Table widget
#2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estherk15
approved these changes
Feb 26, 2025
| @@ -5612,11 +5612,21 @@ Optional: | |||
|
|
|||
| - `alias` (String) An expression alias. | |||
| - `cell_display_mode` (String) A list of display modes for each table cell. Valid values are `number`, `bar`, `trend`. | |||
| - `cell_display_mode_options` (Block List, Max: 1) A list of display modes for each table cell. (see [below for nested schema](#nestedblock--widget--group_definition--widget--query_table_definition--request--formula--cell_display_mode_options)) | |||
There was a problem hiding this comment.
I realize this might be out of scope for this PR, but recommend removing directional language like "below". Instead just point to the section "For a nested schema, see X."
There was a problem hiding this comment.
In fact, we are not writing anything in docs/resources/ and docs/data-sources. It is generated from a hashicorp documentation tool
It is the standard formatting for terraform provider documentation (and is generated from hashicorp tool : https://github.com/hashicorp/terraform-plugin-docs/blob/main/internal/schemamd/render.go#L95)
Supam
approved these changes
Feb 27, 2025
dashashifrina
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2814
cell_display_mode_options manages the
y_scale)trend_type)This PR adds the
cell_display_mode_optionsonly for Query Table one as it seems to be only for this widget :@DataDog/dashboards-backend , I would like your opinion about that