[Generator] (fix) Support date-time format enrichment #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings with the 'format' fields set to 'date-time' were previously read as strings. Meanwhile the Go client automatically converts them to `*time.Time`. Such fields are now properly converted back to strings when updating the state.
Supam
changed the title
ecdatadog
reviewed
Feb 25, 2025
…neric added a printing filter
ecdatadog
previously approved these changes
Feb 26, 2025
ecdatadog
approved these changes
Feb 26, 2025
Supam
deleted the
thibault.viennot/support-date-time-format-enrichment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Strings with the 'format' fields set to 'date-time' were being read as strings.
Meanwhile the Go client automatically converts them to
*time.Timeand breaks the updateState function.Such fields are now properly converted back to strings when updating the state.
Changes
.generator/src/generator/utils.py