Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_ms_teams_microsoft_workflows_webhook_handle] Added Resource #2849

Conversation

kblackdd
Copy link
Contributor

Added MS Teams Workflows Webhooks Resource

@kblackdd kblackdd changed the title Added MS Teams Workflows Webhooks Resource [datadog_integration_ms_teams_microsoft_workflows_webhook_handle] Added Resource Feb 18, 2025
@kblackdd kblackdd marked this pull request as ready for review February 19, 2025 18:53
@kblackdd kblackdd requested review from a team as code owners February 19, 2025 18:53
buraizu
buraizu previously approved these changes Feb 19, 2025
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one minor update

abravo3641
abravo3641 previously approved these changes Feb 20, 2025
@kblackdd kblackdd dismissed stale reviews from abravo3641 and buraizu via f08db91 February 20, 2025 15:22
@kblackdd kblackdd requested a review from a team as a code owner February 20, 2025 15:22
@kblackdd kblackdd requested a review from ecdatadog February 25, 2025 17:50
@@ -200,6 +200,7 @@ var testFiles2EndpointTags = map[string]string{
"tests/resource_datadog_integration_gcp_sts_test": "integration-gcp",
"tests/resource_datadog_integration_gcp_test": "integration-gcp",
"tests/resource_datadog_integration_microsoft_teams_handle_test": "integration-microsoft-teams",
"tests/resource_datadog_integration_ms_teams_workflows_handle_test": "integration-microsoft-teams",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is a copy/paste from the previous line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the correct value be? My understanding was that since both tests were part of the same integration, they would have the same value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's do that way

@ecdatadog ecdatadog self-requested a review February 27, 2025 15:11
ecdatadog
ecdatadog previously approved these changes Feb 27, 2025
@ecdatadog ecdatadog merged commit c2642e1 into master Feb 28, 2025
10 checks passed
@ecdatadog ecdatadog deleted the kalil.black/CHATINTS-500/add-ms-teams-workflows-handle-resource branch February 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants