Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s tests: revamp #3725

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

robertomonteromiguel
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel commented Dec 19, 2024

Motivation

K8s Lib Injection tests

  • Now the scenario will run the K8s Cluster.
  • Delete unused code:
  1. Remove retry wrapper. Now we only run one k8s cluster per machine, we won't have conflicts with the kubectl configuration and open ports.
  2. The test are not parametrized. We can remove the conftest and the parameter object.
  3. Clean unused methods
  • Introduce the "K8s provider" concept. We allow three provideers:
  1. Kind Cluster: Default provider. This provider is local managed, that it's mean its lifecycle is managed by the system-tests scenario (start and stop cluster from the system-tests scenario).
  2. MiniKube: Using a command parameter, you can run the tests using a MiniKube cluster. This provider is local managed. The system-tests will start and stop the cluster.
  3. AWS EKS: Beta provider. It's not locally managed. You need to run the remote cluster manually
    and be sure that the Kubectl has the correct access.
  • Update the documentation.
  • Remove the tests from GitHub actions. We only keep the image validation scenarios and the weblog build process.
  • Add the new K8s Lib Injection tests to Gitlab as part of the SSI pipeline

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review December 30, 2024 07:41
@robertomonteromiguel robertomonteromiguel requested review from a team as code owners December 30, 2024 07:41
@pawelchcki
Copy link
Collaborator

Nice! - The initial clluster setup seems a bit cleaner and more flexible.

The following configuration of the cluster itself - I still think is a little bit hard to follow, but I can't offer a better alternative for now :|

Otherwise looks good to me !

@cbeauchesne
Copy link
Collaborator

Good job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants