Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unreachable host keyrings #238

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix unreachable host keyrings #238

merged 2 commits into from
Jan 19, 2024

Conversation

paulcacheux
Copy link
Collaborator

@paulcacheux paulcacheux commented Jan 17, 2024 •
edited
Loading

In some cases, repositories can be signed by keys that nikos cannot reach, example:

deb [signed-by=/usr/share/keyrings/cuda-archive-keyring.gpg] https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ /

since /host/usr doesn't exist.

In this case it's better to not even add the repository since it will fail when downloading.

Tested and validated using a custom agent build

@paulcacheux paulcacheux marked this pull request as ready for review January 18, 2024 14:34
@paulcacheux paulcacheux requested review from a team as code owners January 18, 2024 14:34
@paulcacheux paulcacheux merged commit 85a7961 into main Jan 19, 2024
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebauce lebauce lebauce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcacheux @lebauce