Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cuda repo parsing #235

Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix cuda repo parsing #235

merged 4 commits into from
Jan 15, 2024

Conversation

paulcacheux
Copy link
Collaborator

@paulcacheux paulcacheux commented Jan 11, 2024

This PR fixes some repository parsing that was wrong. Especially the following repo:

>> cat /host/etc/apt/sources.list.d/cuda-ubuntu2204-x86_64.list
deb [signed-by=/usr/share/keyrings/cuda-archive-keyring.gpg] https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ /

Fixes:

  • components parsing: strings.Split("", " ") == []string{""} (and not nil), which was confusing the components splitting
  • the options parsing was done incorrectly by the upstream lib resulting in bad detection of the URI/distribution/components

Since the upstream APT lib is unmaintained, it was decided to simply bring the small function into our own code, with the added fixes.

@paulcacheux paulcacheux force-pushed the paulcacheux/fix-cuda-parsing branch from d9247d7 to 4ddc36c Compare January 15, 2024 09:45
@paulcacheux paulcacheux marked this pull request as ready for review January 15, 2024 15:05
@paulcacheux paulcacheux requested review from a team as code owners January 15, 2024 15:05
@paulcacheux paulcacheux merged commit eded101 into main Jan 15, 2024
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants