Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug dependency to gemfiles #4299

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add debug dependency to gemfiles #4299

wants to merge 6 commits into from

Conversation

p-datadog
Copy link
Member

What does this PR do?

Adds dependency on debug

Motivation:

I would like to use a debugger in dd-trace-rb

Change log entry
None

Additional Notes:

This replaces the earlier byebug addition request (#4188)

How to test the change?
N/A

@p-datadog p-datadog requested a review from a team as a code owner January 16, 2025 17:32
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 16, 2025

Datadog Report

Branch report: debug-dep
Commit report: ce50a1c
Test service: dd-trace-rb

✅ 0 Failed, 22431 Passed, 1488 Skipped, 5m 26.17s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 21:07:22

Comparing candidate commit ce50a1c in PR branch debug-dep with baseline commit 3d54001 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu
Copy link
Contributor

If you do not need this gem to be added to all the gemfiles, have you consider placing it within the dev group from the gemfiles at root?

@p-datadog
Copy link
Member Author

Some of the integrations had a dependency on byebug which serves the same function - I replaced it with a dependency on debug to be consistent.

@p-datadog
Copy link
Member Author

I also removed byebug requires because they existed in a minority of applications. If we want the debugger to be always required I can do that everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants