-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iast): header source in werkzeug 3.1 #12213
chore(iast): header source in werkzeug 3.1 #12213
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 49.52s Total duration (24m 51.05s time saved) |
BenchmarksBenchmark execution time: 2025-02-05 08:35:27 Comparing candidate commit 0ffc9b1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
IAST taint source Header wouldn't work correctly in `werkzeug>=3.1.0` We're tainting `EnvironHeaders.__getitem__` due to get method calls to `__getitem__` https://github.com/pallets/werkzeug/blob/2.3.8/src/werkzeug/datastructures/headers.py but now the `__getitem__` and `get` methods of `EnvironHeaders` are completely differents: https://github.com/pallets/werkzeug/blob/main/src/werkzeug/datastructures/headers.py ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
IAST taint source Header wouldn't work correctly in
werkzeug>=3.1.0
We're tainting
EnvironHeaders.__getitem__
due to get method calls to__getitem__
https://github.com/pallets/werkzeug/blob/2.3.8/src/werkzeug/datastructures/headers.py
but now the
__getitem__
andget
methods ofEnvironHeaders
are completely differents:https://github.com/pallets/werkzeug/blob/main/src/werkzeug/datastructures/headers.py
Checklist
Reviewer Checklist