-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): remove deprecated modules [3.0] #12186
chore(tracing): remove deprecated modules [3.0] #12186
Conversation
…r/remove-deprecated-tracing-modules
…r/remove-deprecated-tracing-modules
…r/remove-deprecated-tracing-modules
…r/remove-deprecated-tracing-modules
…r/remove-deprecated-tracing-modules
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 35.05s Total duration (24m 49.84s time saved) |
BenchmarksBenchmark execution time: 2025-02-04 06:21:33 Comparing candidate commit dfc581f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 326 metrics, 2 unstable metrics. |
releasenotes/notes/remove-deprecated-tracing-modules-a129231d42e1218d.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-deprecated-tracing-modules-a129231d42e1218d.yaml
Outdated
Show resolved
Hide resolved
…2e1218d.yaml Co-authored-by: Zachary Groves <[email protected]>
6145686
to
8be593b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
a886c24
to
9c6a0ca
Compare
9c6a0ca
to
dfc581f
Compare
#12186 removed deprecated parameters from `tracer.configure(...)` and `rate_limiter.allowed(...)` but did not update the microbenchmarks. This PR address this issue. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Checklist
Reviewer Checklist