Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): remove deprecated modules [3.0] #12186

Merged
merged 59 commits into from
Feb 4, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 31, 2025

  • Removes all tracing modules and packages that are not defined in ddtrace._trace, ddtrace.internal, or ddtrace.trace.
  • Removes deprecated tracing attributes from ddtrace. ddtrace.trace should be the sole public interface for tracing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

mabdinur and others added 30 commits January 27, 2025 17:29
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 31, 2025

Datadog Report

Branch report: munir/remove-deprecated-tracing-modules
Commit report: dfc581f
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 35.05s Total duration (24m 49.84s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-02-04 06:21:33

Comparing candidate commit dfc581f in PR branch munir/remove-deprecated-tracing-modules with baseline commit e294f47 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 326 metrics, 2 unstable metrics.

Base automatically changed from munir/upgrade-min-aws-lambda to 3.x-staging January 31, 2025 17:17
@mabdinur mabdinur enabled auto-merge (squash) February 3, 2025 13:30
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch 2 times, most recently from 6145686 to 8be593b Compare February 3, 2025 22:06
Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mabdinur mabdinur requested a review from a team as a code owner February 3, 2025 23:15
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from a886c24 to 9c6a0ca Compare February 4, 2025 05:18
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from 9c6a0ca to dfc581f Compare February 4, 2025 05:33
@mabdinur mabdinur merged commit 63d13ab into 3.x-staging Feb 4, 2025
734 checks passed
@mabdinur mabdinur deleted the munir/remove-deprecated-tracing-modules branch February 4, 2025 06:22
mabdinur added a commit that referenced this pull request Feb 4, 2025
#12186 removed deprecated
parameters from `tracer.configure(...)` and `rate_limiter.allowed(...)`
but did not update the microbenchmarks. This PR address this issue.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants