Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(configurations): remove deprecated tracing env vars #12176

Merged
merged 22 commits into from
Feb 5, 2025
Merged

chore(configurations): remove deprecated tracing env vars #12176

merged 22 commits into from
Feb 5, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 30, 2025 •
edited
Loading

Blocked by: DataDog/system-tests#3976

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners January 30, 2025 17:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

releasenotes/notes/remove-deprecated-tracing-configs-c6711b57037576f6.yaml  @DataDog/apm-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
ddtrace/settings/_otel_remapper.py                                      @DataDog/apm-core-python
ddtrace/settings/integration.py                                         @DataDog/apm-core-python
docs/advanced_usage.rst                                                 @DataDog/python-guild
docs/configuration.rst                                                  @DataDog/python-guild
tests/appsec/iast/test_processor.py                                     @DataDog/asm-python
tests/integration/test_settings.py                                      @DataDog/apm-core-python
tests/internal/test_settings.py                                         @DataDog/apm-core-python
tests/opentelemetry/test_config.py                                      @DataDog/apm-sdk-api-python
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python
tests/tracer/test_sampler.py                                            @DataDog/apm-sdk-api-python

mabdinur
mabdinur commented Jan 30, 2025
View reviewed changes
ddtrace/settings/_config.py Outdated Show resolved Hide resolved
@mabdinur mabdinur requested a review from mtoffl01 January 30, 2025 17:58
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025 •
edited
Loading

Datadog Report

Branch report: munir/remove-deprecated-tracing-configs
Commit report: 869b67f
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 50.54s Total duration (24m 59.02s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-02-04 23:35:09

Comparing candidate commit 869b67f in PR branch munir/remove-deprecated-tracing-configs with baseline commit be50fd7 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur requested a review from a team as a code owner January 30, 2025 20:58
@mabdinur mabdinur requested a review from gnufede January 31, 2025 15:07
gnufede
gnufede reviewed Jan 31, 2025
View reviewed changes
docs/configuration.rst Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Jan 31, 2025
View reviewed changes
docs/configuration.rst Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Jan 31, 2025
View reviewed changes
docs/configuration.rst Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Feb 3, 2025
View reviewed changes
ddtrace/settings/_config.py Outdated Show resolved Hide resolved
@mabdinur mabdinur enabled auto-merge (squash) February 4, 2025 12:51
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-configs branch from 314b6f7 to 4a26455 Compare February 4, 2025 19:56
@mabdinur mabdinur merged commit a2b1d7b into 3.x-staging Feb 5, 2025
734 checks passed
@mabdinur mabdinur deleted the munir/remove-deprecated-tracing-configs branch February 5, 2025 01:17
ZStriker19 pushed a commit that referenced this pull request Feb 6, 2025
@mabdinur @ZStriker19
chore(configurations): remove deprecated tracing env vars (#12176)
762a160 
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@gnufede gnufede gnufede approved these changes

@emmettbutler emmettbutler emmettbutler approved these changes

@ZStriker19 ZStriker19 ZStriker19 approved these changes

@rachelyangdog rachelyangdog Awaiting requested review from rachelyangdog rachelyangdog is a code owner automatically assigned from DataDog/apm-sdk-api-python

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87 P403n1x87 is a code owner automatically assigned from DataDog/python-guild

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mabdinur @gnufede @emmettbutler @ZStriker19