Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci, profiling): build native macos arm64 wheel [backport 2.20] #12126

Open
wants to merge 5 commits into
base: 2.20
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 28, 2025

Backport b922886 from #12029 to 2.20.

Use macos-latest (M1) runner to build arm64 wheel, instead of building universal2 wheel on macos-13 (intel x86_64).

universal2 wheels didn't have native modules to run profiling with certain features.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot added the Profiling Continous Profling label Jan 28, 2025
@github-actions github-actions bot requested review from a team as code owners January 28, 2025 14:41
@taegyunkim taegyunkim closed this Jan 28, 2025
@taegyunkim taegyunkim reopened this Jan 28, 2025
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/ci-mac-build-37f7e55c8289de61.yaml                   @DataDog/apm-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/datadog/profiling/cmake/AnalysisFunc.cmake             @DataDog/profiling-python
ddtrace/internal/datadog/profiling/crashtracker/CMakeLists.txt          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/CMakeLists.txt                  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt              @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack_v2/test/CMakeLists.txt         @DataDog/profiling-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025

Datadog Report

Branch report: backport-12029-to-2.20
Commit report: 6b2a1e3
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 46.69s Total duration (35m 56.66s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-02-05 16:51:28

Comparing candidate commit 6b2a1e3 in PR branch backport-12029-to-2.20 with baseline commit ad8057c in branch 2.20.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 362 metrics, 2 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) February 4, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants