-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(llmobs): fix token extraction for chat completion streams #12070
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1378 Skipped, 4m 30.37s Total duration (35m 51.08s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as this fix is low risk and high priority and we're just blocked by our testing framework (vcrpy). Let's follow up this PR with tests next week.
Fixes token chunk extraction to account for the
choices
field in a chunk being an empty listBefore
After
Traced succesfully
Checklist
Reviewer Checklist