fix: set span error metadata only for escaped errors #12004
+10
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we set some span error metadata for every call of record_exception. This would set the span as an errored span. However, we can call several times record_exception within a span and we can pass handled exceptions as arguments. In the later case, we want the span not to be errored.
This change aims at addressing this. We will set the relevant metadata only if the error is escaped (which means unhandled).
Checklist
Reviewer Checklist