Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): [MLOB-2064] add telemetry for custom vs. autoinstrumented span creation #11983

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

ncybul
Copy link
Contributor

@ncybul ncybul commented Jan 16, 2025

Adds telemetry to track the number of LLMObs spans created either via auto instrumentation or manual instrumentation.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ncybul ncybul changed the title add telemetry for custom vs. autoinstrumented span creation [MLOB-2064] add telemetry for custom vs. autoinstrumented span creation Jan 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/llmobs/_integrations/base.py                                    @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability

@ncybul ncybul changed the title [MLOB-2064] add telemetry for custom vs. autoinstrumented span creation chore(llmobs): [MLOB-2064] add telemetry for custom vs. autoinstrumented span creation Jan 16, 2025
@ncybul ncybul added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-24 20:14:02

Comparing candidate commit 9099e10 in PR branch nicole-cybul/add-span-count-telemetry with baseline commit b90fa38 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple!

ddtrace/llmobs/_llmobs.py Outdated Show resolved Hide resolved
@ncybul ncybul marked this pull request as ready for review January 24, 2025 20:21
@ncybul ncybul requested a review from a team as a code owner January 24, 2025 20:21
@ncybul ncybul merged commit de71af1 into main Jan 24, 2025
329 of 330 checks passed
@ncybul ncybul deleted the nicole-cybul/add-span-count-telemetry branch January 24, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants