Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): update python version for threats tests #11893

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jan 10, 2025

Update the python version for threats tests, to include python 3.13 when available.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 10, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 10, 2025

Datadog Report

Branch report: christophe-papazian/update_python_version_for_threats_tests
Commit report: cf77846
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 55.86s Total duration (35m 37.07s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 13:29:05

Comparing candidate commit cf77846 in PR branch christophe-papazian/update_python_version_for_threats_tests with baseline commit afe439e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 384 metrics, 0 unstable metrics.

@christophe-papazian christophe-papazian marked this pull request as ready for review January 10, 2025 11:46
@christophe-papazian christophe-papazian requested a review from a team as a code owner January 10, 2025 11:46
@christophe-papazian christophe-papazian enabled auto-merge (squash) January 10, 2025 11:47
hatch.toml Outdated Show resolved Hide resolved
@christophe-papazian christophe-papazian merged commit 1020545 into main Jan 10, 2025
680 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/update_python_version_for_threats_tests branch January 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants