Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): access lock acquired time only when the lock is held #11881

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 8, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 8, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-lock-acquired-at-e308547cffdca9f7.yaml     @DataDog/apm-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python

@taegyunkim taegyunkim marked this pull request as ready for review January 8, 2025 23:15
@taegyunkim taegyunkim requested a review from a team as a code owner January 8, 2025 23:15
@taegyunkim taegyunkim added the Profiling Continous Profling label Jan 8, 2025
@taegyunkim taegyunkim changed the title fix(profiling): access lock acuiqred time only when the lock is held fix(profiling): access lock acquired time only when the lock is held Jan 8, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 8, 2025

Datadog Report

Branch report: taegyunkim/prof-11054-lock
Commit report: c49c13a
Test service: dd-trace-py

✅ 0 Failed, 185 Passed, 1370 Skipped, 4m 55.72s Total duration (34m 46.76s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025

Benchmarks

Benchmark execution time: 2025-01-09 23:01:27

Comparing candidate commit 2c82d3d in PR branch taegyunkim/prof-11054-lock with baseline commit 04ee68f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@taegyunkim taegyunkim requested a review from a team as a code owner January 9, 2025 21:14
@taegyunkim taegyunkim merged commit 6291397 into main Jan 9, 2025
263 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-11054-lock branch January 9, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error in profiling, _ProfiledThreadingLock object has no attribute _self_acquired_at
2 participants