Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(profiling): gh action to run native tests with sanitizers #11623

Merged
merged 28 commits into from
Dec 9, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Dec 4, 2024

  1. Adds a GitHub action running profiling native tests with {thread, safety} sanitizers
  2. Adds Thread sanitizer suppressions list
  3. Updates echion commit to point to taegyunkim/algorithm-include from taegyunkim/macos-fix, taegyunkim/echion@taegyunkim/macos-fix...taegyunkim:echion:taegyunkim/algorithm-include This change was necessary to compile native tests on the actions ubuntu runner.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 4, 2024

CODEOWNERS have been resolved as:

.github/workflows/profiling-native.yml                                  @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/TSan.supp            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/CMakeLists.txt       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt              @DataDog/profiling-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 4, 2024

Datadog Report

Branch report: taegyunkim/prof-10916-gh-actions
Commit report: 9ec78a8
Test service: dd-trace-py

✅ 0 Failed, 24 Passed, 395 Skipped, 6.94s Total duration (4m 8.89s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2024

Benchmarks

Benchmark execution time: 2024-12-09 20:49:49

Comparing candidate commit 9c4ff3d in PR branch taegyunkim/prof-10916-gh-actions with baseline commit dcfaed4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@taegyunkim taegyunkim changed the title chore(profiling): gh action with sanitized native tests ci(profiling): gh action with sanitized native tests Dec 9, 2024
@taegyunkim taegyunkim changed the title ci(profiling): gh action with sanitized native tests ci(profiling): gh action to run native tests with sanitizers Dec 9, 2024
@taegyunkim taegyunkim marked this pull request as ready for review December 9, 2024 19:52
@taegyunkim taegyunkim requested review from a team as code owners December 9, 2024 19:52
@taegyunkim taegyunkim added Profiling Continous Profling changelog/no-changelog A changelog entry is not required for this PR. labels Dec 9, 2024
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taegyunkim taegyunkim merged commit 3232531 into main Dec 9, 2024
202 of 203 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-10916-gh-actions branch December 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants