Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): use clang when --safety is set #11619

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Dec 4, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner December 4, 2024 21:30
@taegyunkim taegyunkim added Profiling Continous Profling changelog/no-changelog A changelog entry is not required for this PR. labels Dec 4, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) December 4, 2024 21:30
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/build_standalone.sh                  @DataDog/profiling-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: taegyunkim/prof-10916-set-clang
Commit report: b69e22a
Test service: dd-trace-py

✅ 0 Failed, 1172 Passed, 296 Skipped, 5m 9.53s Total duration (16m 40.98s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2024

Benchmarks

Benchmark execution time: 2024-12-04 22:16:13

Comparing candidate commit b69e22a in PR branch taegyunkim/prof-10916-set-clang with baseline commit 79be26d in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟩 execution_time [-485.282ns; -427.579ns] or [-13.258%; -11.682%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-588.757ns; -519.177ns] or [-14.184%; -12.507%]

@taegyunkim taegyunkim merged commit 7f9c619 into main Dec 5, 2024
194 of 196 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-10916-set-clang branch December 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants