Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): make sanitizers happy #11448

Closed
wants to merge 87 commits into from

Conversation

taegyunkim
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 19, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/dd_wrapper/include/vendored/concurrentqueue.h  @DataDog/profiling-python
releasenotes/notes/profiling-reset-lock-51a032479617f038.yaml           @DataDog/apm-python
ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/cmake/tools/libdatadog_checksums.txt  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/sample_manager.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/synchronized_sample_pool.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/profile.cpp           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/synchronized_sample_pool.cpp  @DataDog/profiling-python
scripts/cformat.sh                                                      @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2024

Benchmarks

Benchmark execution time: 2024-12-09 21:39:56

Comparing candidate commit 7c80d18 in PR branch taegyunkim/prof-10916-sanitizer-fixes with baseline commit 3232531 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@taegyunkim taegyunkim force-pushed the taegyunkim/prof-10916-sanitizer-fixes branch from d50223c to 35aef24 Compare December 4, 2024 19:46
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 4, 2024

Datadog Report

Branch report: taegyunkim/prof-10916-sanitizer-fixes
Commit report: edc6456
Test service: dd-trace-py

✅ 0 Failed, 23 Passed, 1445 Skipped, 1m 15.31s Total duration (35m 32.13s time saved)

@taegyunkim taegyunkim force-pushed the taegyunkim/prof-10916-sanitizer-fixes branch from 1547f53 to e97a2c0 Compare December 5, 2024 22:56
@taegyunkim taegyunkim force-pushed the taegyunkim/prof-10916-sanitizer-fixes branch from 05ddcc8 to 1fca2c3 Compare December 9, 2024 15:56
@taegyunkim taegyunkim force-pushed the taegyunkim/prof-10916-sanitizer-fixes branch from 1fca2c3 to 92a2733 Compare December 9, 2024 15:56
@taegyunkim taegyunkim closed this Dec 16, 2024
@taegyunkim taegyunkim deleted the taegyunkim/prof-10916-sanitizer-fixes branch December 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant