Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate (and expired) flaky marker from the aws lambda test #11428

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Nov 15, 2024

There's currently two flaky decorators on the test aws lambda file.

@flaky(1735812000) -> Jan 2, 2025
@flaky(1709306303) -> March 1, 2024

The purpose of this is to remove the expired one.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui requested review from a team as code owners November 15, 2024 20:09
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/aws_lambda/test_aws_lambda.py                             @DataDog/apm-core-python @DataDog/apm-idm-python

@wantsui wantsui changed the title chore: remove duplicate (and expired) flaky marker from the aws lambda test. chore: remove duplicate (and expired) flaky marker from the aws lambda test Nov 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-18 23:19:35

Comparing candidate commit ef36f94 in PR branch wantsui/remove-duplicate-flaky-from-aws with baseline commit 5f7d6a0 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 385 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+716.891ns; +781.210ns] or [+19.333%; +21.067%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+457.449ns; +529.863ns] or [+8.849%; +10.250%]

scenario:iast_aspects-rsplit_aspect

  • 🟥 execution_time [+131.522ns; +159.616ns] or [+7.399%; +8.980%]

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 15, 2024
@wantsui
Copy link
Collaborator Author

wantsui commented Nov 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-18 18:43:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-18 19:12:11 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 4980e93:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@wantsui
Copy link
Collaborator Author

wantsui commented Nov 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-19 15:32:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-19 15:57:28 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit ca6be8c:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants