chore: use guess-next-dev instead of release-branch-semver [erikatest] #11426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikayasuda
requested review from
christophe-papazian
and removed request for
a team
erikayasuda
added
the
changelog/no-changelog
|
|
2 tasks
erikayasuda
added a commit
that referenced
this pull request
Nov 19, 2024
This PR automates two manual steps in the release process: - Creating the new release branch for minor versions (ex - `2.17` branch after 2.17.0rc1 is built and published, so contributors can backport) - Automating [these manual PRs](#11228) to update the `version_scheme` in the `pyproject.toml` file from `release-branch-semver` to `guess-next-dev`. This is a required step in the release process after the first release candidate is triggered to ensure system tests work properly for backports. See sample PR that was generated via testing here: #11426 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
version_schemain the../pyproject.tomlfile for the erikatest release branch fromrelease-branch-semvertoguess-next-dev. This is to ensure that system tests work as intended with backports to this release branch.IMPORTANT: This PR needs to be merged before the first backport is created for erikatest.Otherwise, system tests will not work as expected.