-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): fix inferred base service for pytest command ran with --ddtrace optional argument #11394
Conversation
|
BenchmarksBenchmark execution time: 2024-11-19 20:15:56 Comparing candidate commit aa7137d in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 24m 35.43s Total duration (13m 18.08s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just ensuring tests are aware of the inferred test service names right? Wasn't able to find anything else in this PR. Otherwise LGTM from team mlobs
releasenotes/notes/fix-pytest-inferred-service-naming-5ba12e991d040a1b.yaml
Outdated
Show resolved
Hide resolved
Unfortunately we can't cover every case of single-arg options for executables run with ddtrace, but we should at the very least recognize this option (it also affects our testing and was causing CI service names != locally tested service names for the same set of tests. |
/merge |
Devflow running:
|
/merge |
Devflow running:
|
… --ddtrace optional argument (#11394) # Motivation Add special case for `--ddtrace` pytest argument, that was causing CI tests to have a different service name than local testing. CI testing adds the `--ddtrace` arg to the command. Previously the code would skip any args that started with `-` as well as the following arg, but that should not be the case for this arg. (cherry picked from commit 7297779)
… --ddtrace optional argument [backport 2.17] (#11447) Backport 7297779 from #11394 to 2.17. # Motiviation Add special case for `--ddtrace` pytest argument, that was causing CI tests to have a different service name than local testing. CI testing adds the `--ddtrace` arg to the command. Previously the code would skip any args that started with `-` as well as the following arg, but that should not be the case for this arg. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: William Conti <[email protected]>
Motiviation
Add special case for
--ddtrace
pytest argument, that was causing CI tests to have a different service name than local testing. CI testing adds the--ddtrace
arg to the command. Previously the code would skip any args that started with-
as well as the following arg, but that should not be the case for this arg.Checklist
Reviewer Checklist