Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): fix inferred base service for pytest command ran with --ddtrace optional argument #11394

Merged
merged 24 commits into from
Nov 19, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Nov 13, 2024

Motiviation

Add special case for --ddtrace pytest argument, that was causing CI tests to have a different service name than local testing. CI testing adds the --ddtrace arg to the command. Previously the code would skip any args that started with - as well as the following arg, but that should not be the case for this arg.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 13, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/fix-pytest-inferred-service-naming-5ba12e991d040a1b.yaml  @DataDog/apm-python
ddtrace/contrib/internal/mako/patch.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/sampler.py                                                      @DataDog/apm-sdk-api-python
ddtrace/settings/_inferred_base_service.py                              @DataDog/apm-core-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python
tests/contrib/anthropic/test_anthropic_llmobs.py                        @DataDog/ml-observability
tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/flask/test_blueprint.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/flask/test_errorhandler.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/flask/test_flask_helpers.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/flask/test_template.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/flask/test_views.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/google_generativeai/test_google_generativeai_llmobs.py    @DataDog/ml-observability
tests/contrib/httplib/test_httplib.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/httpx/test_httpx.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/httpx/test_httpx_pre_0_11.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/jinja2/test_jinja2.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability
tests/contrib/langchain/test_langchain_community.py                     @DataDog/ml-observability
tests/contrib/langchain/test_langchain_llmobs.py                        @DataDog/ml-observability
tests/contrib/logging/test_logging.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/openai/test_openai_llmobs.py                              @DataDog/ml-observability
tests/contrib/openai/test_openai_v0.py                                  @DataDog/ml-observability
tests/contrib/openai/test_openai_v1.py                                  @DataDog/ml-observability
tests/debugging/test_config.py                                          @DataDog/debugger-python
tests/integration/test_debug.py                                         @DataDog/apm-core-python
tests/internal/remoteconfig/test_remoteconfig_client_e2e.py             @DataDog/remote-config @DataDog/apm-core-python
tests/internal/service_name/test_inferred_base_service.py               @DataDog/apm-core-python
tests/llmobs/_utils.py                                                  @DataDog/ml-observability
tests/llmobs/test_llmobs_span_agent_writer.py                           @DataDog/ml-observability
tests/llmobs/test_llmobs_span_agentless_writer.py                       @DataDog/ml-observability
tests/llmobs/test_llmobs_trace_processor.py                             @DataDog/ml-observability
tests/snapshots/test_extended_sampling_float_special_case_do_not_match.json  @DataDog/apm-python
tests/snapshots/test_extended_sampling_float_special_case_match_star.json  @DataDog/apm-python
tests/snapshots/test_extended_sampling_glob_multi_rule.json             @DataDog/apm-python
tests/snapshots/test_extended_sampling_resource.json                    @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags.json                        @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_and_name_glob.json          @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_and_resource.json           @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_and_resource_glob.json      @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_and_service_glob.json       @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_glob.json                   @DataDog/apm-python
tests/snapshots/test_extended_sampling_tags_glob_insensitive_case_match.json  @DataDog/apm-python
tests/snapshots/test_extended_sampling_w_None.json                      @DataDog/apm-python
tests/snapshots/test_extended_sampling_w_None_meta.json                 @DataDog/apm-python
tests/snapshots/test_extended_sampling_w_metrics.json                   @DataDog/apm-python
tests/snapshots/test_extended_sampling_w_tags_none.json                 @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_1.json           @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_1_and_manual_drop.json  @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_1_and_manual_keep.json  @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_1_and_rule_0.json  @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_1_and_rule_1.json  @DataDog/apm-python
tests/snapshots/test_sampling_with_default_sample_rate_tiny.json        @DataDog/apm-python
tests/snapshots/test_sampling_with_defaults.json                        @DataDog/apm-python
tests/snapshots/test_sampling_with_rate_limit_3.json                    @DataDog/apm-python
tests/snapshots/test_sampling_with_rate_sampler_with_tiny_rate.json     @DataDog/apm-python
tests/snapshots/test_sampling_with_sample_rate_1_and_rate_limit_0.json  @DataDog/apm-python
tests/snapshots/test_sampling_with_sample_rate_1_and_rate_limit_3_and_rule_0.json  @DataDog/apm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_body_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_cookies_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_span_tags_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_span_tags_snapshot_with_errors.json  @DataDog/asm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_200_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_200_request_post.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_500_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_configure_service_name_split_by_domain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_trace_multiple.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_trace_parenting.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_trace_query_string.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp_jinja2.test_aiohttp_jinja2.test_template_rendering_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp_jinja2.test_aiohttp_jinja2.test_template_rendering_snapshot[pyloop].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aiohttp_jinja2.test_aiohttp_jinja2.test_template_rendering_snapshot_patched_server[True].json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_create_image.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_multiple_prompts.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_multiple_prompts_with_chat_history.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_stream_helper.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_stream_image.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_tools.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_tools_full_use.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_tools_full_use_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_tools_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_tools_stream_helper.json  @DataDog/apm-python
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm_unserializable_arg.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_analytics_with_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_analytics_without_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_basics.json       @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_cmd_max_length.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_full_command_in_resource_config[True].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_long_command.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_opentracing.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_pipeline_immediate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_pipeline_traced.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aredis.test_aredis.test_unicode.json      @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_404_exceptions.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_middleware_trace_callable_view.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_safe_string_encoding.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_streamed_file.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django_hosts.test_django.test_django_hosts_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_fn_exception_no_retries.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_fn_retry_exception.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_fn_task_send.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_fn_task_send_with_params.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_idempotent_patch.json  @DataDog/apm-python
tests/snapshots/tests.contrib.dramatiq.test_integration.test_send_exception.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_500_error_raised.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_background_task.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_subapp_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_table_query_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_traced_websocket.json  @DataDog/apm-python
tests/snapshots/tests.contrib.fastapi.test_fastapi.test_tracing_in_middleware.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_image.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_multiple_messages.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_system_prompt.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_completion_tool_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_tool_chat_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.google_generativeai.test_google_generativeai.test_gemini_tool_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphene.test_graphene.test_schema_execute.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphene.test_graphene.test_schema_execute_with_resolvers.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphene.test_graphene.test_schema_failing_execute.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql.json    @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_execute_with_middleware.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_with_document_with_no_location.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_with_traced_resolver.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_configure_service_name.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_get_200.json        @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_get_500.json        @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_request_headers.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_schematized_unspecified_service_name_env_default.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_schematized_unspecified_service_name_env_v0.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_split_by_domain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.httpx.test_httpx.test_trace_query_string.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_ai21_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_cohere_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_cohere_math_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_fake_embedding_document.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_fake_embedding_query.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_huggingfacehub_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_call.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_call_39.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_call_langchain_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_generate_39.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_embedding_document.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_embedding_query.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync_39.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync_multiple_prompts.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync_multiple_prompts_39.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_math_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_sequential_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_sequential_chain_with_multiple_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_sequential_chain_with_multiple_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_pinecone_vectorstore_retrieval_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_pinecone_vectorstore_retrieval_chain_39.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_pinecone_vectorstore_similarity_search.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_ai21_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_base_tool_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_base_tool_invoke_non_json_serializable_config.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_chain_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_cohere_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_faiss_vectorstore_retrieval.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_fake_embedding_document.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_fake_embedding_query.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_huggingfacehub_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcecl_chain_non_dict_input.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch_311.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_batch_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_complicated.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_nested.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_non_dict_input.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_simple.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_chain_simple_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_with_tools_anthropic.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_lcel_with_tools_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_chat_model_async_call.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_chat_model_async_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_chat_model_sync_call_langchain_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_chat_model_sync_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_chat_model_vision_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_embedding_query.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_llm_sync_multiple_prompts.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_math_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_math_chain_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain_with_multiple_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain_with_multiple_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_pinecone_vectorstore_retrieval_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_pinecone_vectorstore_similarity_search.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_streamed_chain.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_streamed_chat.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_streamed_json_output_parser.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain_community.test_streamed_llm.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_acompletion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_atranscribe.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_atranslate.json   @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_azure_openai_chat_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_azure_openai_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_azure_openai_embedding.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_chat_completion.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_chat_completion_function_calling.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_chat_completion_image_input.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_completion.json   @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_create_moderation.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_embedding.json    @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_embedding_array_of_token_arrays.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_embedding_string_array.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_embedding_token_array.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_file_create.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_file_delete.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_file_download.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_file_list.json    @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_file_retrieve.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_image_b64_json_response.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_image_create.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_image_edit.json   @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_image_edit_binary_input.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_image_variation.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_misuse.json       @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_model_delete.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_model_list.json   @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_model_retrieve.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_span_finish_on_stream_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_transcribe.json   @DataDog/apm-python
tests/snapshots/tests.contrib.openai.test_openai.test_translate.json    @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_analytics_with_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_analytics_without_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_basics.json         @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_custom_cmd_length.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_full_command_in_resource_config.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_long_command.json   @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_meta_override.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_opentracing.json    @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_pipeline_immediate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_pipeline_traced.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis.test_unicode.json        @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_basic_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_client_name.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_connection_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_decoding_non_utf8_args.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_decoding_non_utf8_pipeline_args.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_long_command.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_override_service_name.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_parenting.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_pin.json    @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_pipeline_traced.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_pipeline_traced_context_manager_transaction.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_two_traced_pipelines.json  @DataDog/apm-python
tests/snapshots/tests.contrib.redis.test_redis_asyncio.test_unicode_request.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rediscluster.test.test_cmd_max_length.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rediscluster.test.test_full_command_in_resource_config[True].json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_enqueue_distributed_tracing_enabled_False_worker_service_None.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_enqueue_distributed_tracing_enabled_False_worker_service_custom-worker-service.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_enqueue_distributed_tracing_enabled_None_worker_service_None.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_enqueue_distributed_tracing_enabled_None_worker_service_custom-worker-service.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_queue_failing_job.json    @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_queue_failing_job_pre_1_10_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_queue_pin_service.json    @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_queue_enqueue.json   @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_worker.json          @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_worker_config_service.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_worker_multiple_jobs.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_worker_pin_service.json  @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_sync_worker_ttl.json      @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_worker_class_job.json     @DataDog/apm-python
tests/snapshots/tests.contrib.rq.test_rq.test_worker_failing_job.json   @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_commit.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_executemany_insert.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_fetchall.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_fetchall_multiple_rows.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_fetchone.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_ot_executemany_insert.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_ot_fetchall.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_ot_fetchall_multiple_rows.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_ot_fetchone.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_pin_override.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_rollback.json  @DataDog/apm-python
tests/snapshots/tests.contrib.snowflake.test_snowflake.test_snowflake_settings_override.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_background_task.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_subapp_nested_call_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_subapp_nested_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_subapp_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_subapp_two_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.starlette.test_starlette.test_table_query_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.urllib3.test_urllib3.test_urllib3_connectionpool_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.urllib3.test_urllib3.test_urllib3_poolmanager_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_200.json              @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_500_py3.json          @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_base_exception_in_wsgi_app_py3.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_chunked.json          @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_distributed_tracing_nested.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_generator_exit_ignored_snapshot.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_stop_iteration_in_wsgi_app_py3.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_wsgi_base_middleware.json  @DataDog/apm-python
tests/snapshots/tests.contrib.wsgi.test_wsgi.test_wsgi_base_middleware_500.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_analytics_with_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_analytics_without_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_basics.json   @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_cmd_max_length.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_full_command_in_resource_config[True].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_long_command.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_opentracing.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_pipeline_immediate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_pipeline_traced.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_unicode.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_filters.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_multiple_traces.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_sampling.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_setting_span_tags_and_metrics_generates_no_error_logs[v0.4].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_setting_span_tags_and_metrics_generates_no_error_logs[v0.5].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_single_trace_single_span.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_synchronous_writer.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_trace_with_wrong_metrics_types_not_sent.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_tracer_trace_across_multiple_popens.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_tracer_trace_across_popen.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_tracetagsprocessor_only_adds_new_tags.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_priority_sampling.test_agent_sample_rate_keep.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_priority_sampling.test_agent_sample_rate_reject.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_propagation.test_sampling_decision_downstream.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_propagation.test_trace_tags_multispan[tracer0].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_propagation.test_trace_tags_multispan[tracer1].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_propagation.test_trace_tags_multispan[tracer2].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_measured_span.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_sampling_rate[0.0].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_sampling_rate[1.0].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_single_span_sampling[sampling_rule0].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_single_span_sampling[sampling_rule1].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_stats_30.json   @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_stats_aggrs.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_stats_errors.json  @DataDog/apm-python
tests/snapshots/tests.integration.test_trace_stats.test_top_level.json  @DataDog/apm-python
tests/tracer/runtime/test_runtime_metrics.py                            @DataDog/apm-sdk-api-python
tests/tracer/test_correlation_log_context.py                            @DataDog/apm-sdk-api-python
tests/tracer/test_sampler.py                                            @DataDog/apm-sdk-api-python
tests/tracer/test_settings.py                                           @DataDog/apm-sdk-api-python
tests/tracer/test_trace_utils.py                                        @DataDog/apm-sdk-api-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-19 20:15:56

Comparing candidate commit aa7137d in PR branch conti/fix-pytest-inferred-service with baseline commit cd671e2 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+462.247ns; +520.464ns] or [+8.701%; +9.797%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+578.345ns; +636.149ns] or [+14.893%; +16.381%]

scenario:iast_aspects-ospathsplitdrive_aspect

  • 🟥 execution_time [+253.031ns; +291.944ns] or [+9.369%; +10.810%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+510.951ns; +568.144ns] or [+14.143%; +15.726%]

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 13, 2024

Datadog Report

Branch report: conti/fix-pytest-inferred-service
Commit report: 1abb0ed
Test service: dd-trace-py

✅ 0 Failed, 1468 Passed, 0 Skipped, 24m 35.43s Total duration (13m 18.08s time saved)

@wconti27 wconti27 marked this pull request as ready for review November 14, 2024 18:20
@wconti27 wconti27 requested review from a team as code owners November 14, 2024 18:20
@wconti27 wconti27 self-assigned this Nov 14, 2024
Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just ensuring tests are aware of the inferred test service names right? Wasn't able to find anything else in this PR. Otherwise LGTM from team mlobs

@wconti27
Copy link
Contributor Author

The only customer impact should be limited to those using ddtrace with pytest via the following syntax pytest --ddtrace ...

FWIW, pytest has lots of other single-arg options (eg: pytest -s path/to/my/tests, or -x, etc). It feels a little weird to special-case --ddtrace.

Unfortunately we can't cover every case of single-arg options for executables run with ddtrace, but we should at the very least recognize this option (it also affects our testing and was causing CI service names != locally tested service names for the same set of tests.

@wconti27
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-18 21:19:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-19 01:19:47 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@wconti27
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-19 18:59:54 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-19 19:25:02 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 1f1e530:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@wconti27 wconti27 enabled auto-merge (squash) November 19, 2024 19:50
@wconti27 wconti27 disabled auto-merge November 19, 2024 19:50
@wconti27 wconti27 enabled auto-merge (squash) November 19, 2024 19:50
@wconti27 wconti27 merged commit 7297779 into main Nov 19, 2024
540 checks passed
@wconti27 wconti27 deleted the conti/fix-pytest-inferred-service branch November 19, 2024 20:17
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
… --ddtrace optional argument (#11394)

# Motivation

Add special case for `--ddtrace` pytest argument, that was causing CI tests to have a different service name than local testing. CI testing adds the `--ddtrace` arg to the command. Previously the code would skip any args that started with `-` as well as the following arg, but that should not be the case for this arg.

(cherry picked from commit 7297779)
erikayasuda pushed a commit that referenced this pull request Nov 19, 2024
… --ddtrace optional argument [backport 2.17] (#11447)

Backport 7297779 from #11394 to 2.17.

# Motiviation

Add special case for `--ddtrace` pytest argument, that was causing CI
tests to have a different service name than local testing. CI testing
adds the `--ddtrace` arg to the command. Previously the code would skip
any args that started with `-` as well as the following arg, but that
should not be the case for this arg.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: William Conti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants