Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update starlette latest version to 0.41.2 #11354

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2024

Update starlette lockfiles and dependency package lockfiles.
This performs the following updates:

  1. Some starlette lockfiles use starlette latest. This will update starlette and dependencies.
  2. Some starlette lockfiles use a pinned (non-latest) version of starlette, but require a latest dependency version. This will update the dependencies.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested a review from a team as a code owner November 11, 2024 21:22
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 11, 2024
@github-actions github-actions bot requested review from avara1986 and lievan November 11, 2024 21:22
@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-15 01:00:59

Comparing candidate commit 07d8bca in PR branch upgrade-latest-starlette-version with baseline commit bd0097f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@quinna-h quinna-h closed this Nov 12, 2024
@quinna-h quinna-h reopened this Nov 12, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

.riot/requirements/112dc22.txt                                          @DataDog/apm-python
.riot/requirements/1250d61.txt                                          @DataDog/apm-python
.riot/requirements/156e3cc.txt                                          @DataDog/apm-python
.riot/requirements/17a0f7f.txt                                          @DataDog/apm-python
.riot/requirements/18392ae.txt                                          @DataDog/apm-python
.riot/requirements/1b846e9.txt                                          @DataDog/apm-python
.riot/requirements/1c489e9.txt                                          @DataDog/apm-python
.riot/requirements/2c855a9.txt                                          @DataDog/apm-python
.riot/requirements/41529f2.txt                                          @DataDog/apm-python
.riot/requirements/4b1629e.txt                                          @DataDog/apm-python
.riot/requirements/7b8e50e.txt                                          @DataDog/apm-python
.riot/requirements/7f7863d.txt                                          @DataDog/apm-python
.riot/requirements/7ff8c97.txt                                          @DataDog/apm-python
.riot/requirements/91a3315.txt                                          @DataDog/apm-python
.riot/requirements/b06b6cb.txt                                          @DataDog/apm-python
.riot/requirements/c52f9f6.txt                                          @DataDog/apm-python
.riot/requirements/d6ceb22.txt                                          @DataDog/apm-python
.riot/requirements/d88b3ac.txt                                          @DataDog/apm-python
.riot/requirements/ec338d4.txt                                          @DataDog/apm-python

@quinna-h quinna-h enabled auto-merge (squash) November 12, 2024 21:43
quinna-h added a commit that referenced this pull request Nov 15, 2024
In the auto-generated PRs generated by the [Generate Package
Versions](https://github.com/DataDog/dd-trace-py/actions/workflows/generate-package-versions.yml)
workflow, some of the modified files might not directly update the
selected package to `latest`. Not all lockfiles for a given `venv` will
use the `venv` `latest`, but the workflow also updates dependency
versions.

This PR modifies the body of the generated PRs for better clarification.
Example: #11354

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Emmett Butler <[email protected]>
@quinna-h quinna-h merged commit 5f7d6a0 into main Nov 18, 2024
97 of 98 checks passed
@quinna-h quinna-h deleted the upgrade-latest-starlette-version branch November 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants