Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): order test suite names in jobspec #11340

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Nov 8, 2024

Re-ordered the GitLab test suites to maintain alphabetization. No content change.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 8, 2024
@erikayasuda erikayasuda requested review from a team as code owners November 8, 2024 19:29
Copy link
Contributor

github-actions bot commented Nov 8, 2024

CODEOWNERS have been resolved as:

tests/contrib/jobspec.yml                                               @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 8, 2024

Datadog Report

Branch report: erikayasuda/add-vertica-to-gitlab
Commit report: fd6fb2b
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 604 Skipped, 19m 23.88s Total duration (16m 44.25s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-15 14:33:25

Comparing candidate commit fd6fb2b in PR branch erikayasuda/add-vertica-to-gitlab with baseline commit bd0097f in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics.

scenario:iast_aspects-swapcase_aspect

  • 🟩 execution_time [-400.870ns; -364.333ns] or [-12.214%; -11.101%]

scenario:iast_aspects-title_aspect

  • 🟩 execution_time [-335.328ns; -288.871ns] or [-10.580%; -9.114%]

@erikayasuda erikayasuda marked this pull request as draft November 8, 2024 22:05
@erikayasuda erikayasuda marked this pull request as ready for review November 14, 2024 22:00
@erikayasuda erikayasuda requested a review from a team as a code owner November 14, 2024 22:00
@erikayasuda erikayasuda requested a review from quinna-h November 14, 2024 22:00
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the file has been sorted as well. Can we do the sorting separately to keep the diff clean, pretty please? 🙏

@P403n1x87
Copy link
Contributor

I suspect vertica is something we still can't run in GitLab

. And I discovered #9110

@erikayasuda
Copy link
Contributor Author

It looks like the file has been sorted as well. Can we do the sorting separately to keep the diff clean, pretty please? 🙏

I'll remove the vertica addition and just make this a sorting PR then 👍

@erikayasuda erikayasuda changed the title chore(ci): add vertica test suite to gitlab chore(ci): order test suite names in jobspec Nov 15, 2024
@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-19 18:44:21 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.

@dd-mergequeue dd-mergequeue bot merged commit cd671e2 into main Nov 19, 2024
437 of 440 checks passed
@dd-mergequeue dd-mergequeue bot deleted the erikayasuda/add-vertica-to-gitlab branch November 19, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants