-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use guess-next-dev
instead of release-branch-semver
for versioning [2.16]
#11228
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1286 Passed, 0 Skipped, 30m 11.4s Total duration (8m 25.5s time saved) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #11228 +/- ##
=======================================
Coverage ? 7.45%
=======================================
Files ? 1484
Lines ? 127582
Branches ? 0
=======================================
Hits ? 9509
Misses ? 118073
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This PR automates two manual steps in the release process: - Creating the new release branch for minor versions (ex - `2.17` branch after 2.17.0rc1 is built and published, so contributors can backport) - Automating [these manual PRs](#11228) to update the `version_scheme` in the `pyproject.toml` file from `release-branch-semver` to `guess-next-dev`. This is a required step in the release process after the first release candidate is triggered to ensure system tests work properly for backports. See sample PR that was generated via testing here: #11426 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We need to use
guess-next-dev
for versioning for release branches in order to ensure that system tests can work with them.This is a manual PR, but the goal is to automate this PR generation (probably in the
release.py
script)Great context from internal ticket:
Checklist
Reviewer Checklist