Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format release notes so the release script could parse [backport 2.16] #11226

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024

Backport 44ed02c from #11208 to 2.16.

Release notes with : in them need to be entered as a block with |, otherwise the release script fails to parse it properly

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Release notes with `:` in them need to be entered as a block with `|`,
otherwise the release script fails to parse it properly

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 44ed02c)
@github-actions github-actions bot requested a review from a team as a code owner October 30, 2024 14:06
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected labels Oct 30, 2024
@erikayasuda
Copy link
Contributor

Closing and re-opening to get CI unstuck

auto-merge was automatically disabled October 30, 2024 14:13

Pull request was closed

@erikayasuda erikayasuda reopened this Oct 30, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/ci_visibility-fix_codeowners_including_comments-82d9cb733a2c7285.yaml  @DataDog/apm-python
releasenotes/notes/ci_visibility-fix_logged_errors_when_gitless-66a6cb3245314f3e.yaml  @DataDog/apm-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 22:01:01

Comparing candidate commit 3d8c1c7 in PR branch backport-11208-to-2.16 with baseline commit d9c062a in branch 2.16.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 385 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+235.775ns; +293.785ns] or [+7.150%; +8.909%]

scenario:iast_aspects-replace_aspect

  • 🟩 execution_time [-815.012ns; -740.713ns] or [-11.044%; -10.037%]

scenario:iast_aspects-split_aspect

  • 🟩 execution_time [-185.463ns; -147.518ns] or [-9.941%; -7.907%]

@erikayasuda erikayasuda enabled auto-merge (squash) October 30, 2024 21:40
@erikayasuda erikayasuda merged commit ad88863 into 2.16 Oct 30, 2024
512 checks passed
@erikayasuda erikayasuda deleted the backport-11208-to-2.16 branch October 30, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant