chore(ci): remove django circleci test suite [backport 2.14] #11222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## Context Recently, the django test suite on CircleCI has been consistently failing, which has been blocking many PRs. While investigating, we observed: - that when we migrated the django test suite to GitLab, we didn't remove it from CircleCI (#10611). - we can reproduce the errors we saw on CI when the testagent container isn't spun up locally - the django tests fail consistently with python 3.8 for the snapshot tests in CI, but consistently pass when run locally with a testagent (we tried with `64b33747062c585df9f0eb810c28d367379a9998`: the head commit on `main`, `0c17d211b9fac9d7855966f70530f19ed17e27a3` : @avara1986 's original django fix PR, and `127e5b72ee45e55e4c6d9b7d07922d47099483fb`: the PR that merged right before @avara1986 's fix PR) The root cause of the CirlceCI issue is still under investigation, but given that this is currently blocking PRs from merging but the same tests are already running AND passing in GitLab, this PR aims to remove the django test suite from CircleCI to unblock contributors. @erikayasuda will continue investigating the root cause of the CircleCI issues, but with this PR merged that investigation will not be a blocker. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit c5134f9)
github-actions
bot
added
the
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 592 Passed, 694 Skipped, 21m 15.04s Total duration (17m 50.14s time saved) |
|
|
gnufede
approved these changes
Oct 30, 2024
emmettbutler
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c5134f9 from #11220 to 2.14.
Context
Recently, the django test suite on CircleCI has been consistently failing, which has been blocking many PRs. While investigating, we observed:
64b33747062c585df9f0eb810c28d367379a9998: the head commit onmain,0c17d211b9fac9d7855966f70530f19ed17e27a3: @avara1986 's original django fix PR, and127e5b72ee45e55e4c6d9b7d07922d47099483fb: the PR that merged right before @avara1986 's fix PR)The root cause of the CirlceCI issue is still under investigation, but given that this is currently blocking PRs from merging but the same tests are already running AND passing in GitLab, this PR aims to remove the django test suite from CircleCI to unblock contributors.
@erikayasuda will continue investigating the root cause of the CircleCI issues, but with this PR merged that investigation will not be a blocker.
Checklist
Reviewer Checklist