Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pymongo): add pin type check #11145

Merged
merged 14 commits into from
Oct 30, 2024
Merged

fix(pymongo): add pin type check #11145

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2286068
add pin check
quinna-h Oct 23, 2024
5b6e672
add release note
quinna-h Oct 25, 2024
a7a0ade
Merge branch 'main' into quinna.halim/pymongo-check-type-pin
quinna-h Oct 28, 2024
83cb251
Update releasenotes/notes/pymongo-check-pin-c3cb9d1fbdc82fb3.yaml
quinna-h Oct 28, 2024
297d2ae
Merge branch 'main' into quinna.halim/pymongo-check-type-pin
quinna-h Oct 28, 2024
04ae401
Merge branch 'main' into quinna.halim/pymongo-check-type-pin
quinna-h Oct 29, 2024
4dee5d2
test increase delay in django server
quinna-h Oct 29, 2024
0ca7d49
test change client wait time back to default
quinna-h Oct 29, 2024
337d908
increase initial wait for django server
quinna-h Oct 29, 2024
ccc24fa
add log warning
quinna-h Oct 29, 2024
ecd02c0
make linter happy
quinna-h Oct 29, 2024
d9ceb90
more testing timeout
quinna-h Oct 29, 2024
b1e9496
Merge branch 'main' into quinna.halim/pymongo-check-type-pin
quinna-h Oct 30, 2024
fddd901
revert django snapshot
quinna-h Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ddtrace/contrib/internal/pymongo/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ def _trace_topology_select_server(func, args, kwargs):
# Ensure the pin used on the traced mongo client is passed down to the topology instance
# This allows us to pass the same pin in traced server objects.
topology_instance = get_argument_value(args, kwargs, 0, "self")
ddtrace.Pin.get_from(topology_instance).onto(server)
pin = ddtrace.Pin.get_from(topology_instance)

if pin is not None:
pin.onto(server)
return server


Expand Down
Loading