-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): use unified Gitlab pipeline for APM libraries [backport 2.9] #10529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** Converts the Gitlab workflow to use the unified pipeline. By using the unified pipeline across all APM libraries, there is less maintenance hassle, fewer mistakes, and a more uniform creation of artifacts. Additionally, this change creates OCI packages and lib inject images for every `dd-trace-py` build. Previously, only released versions to pypi were built and tested. The changes can be summarized as follows: * Removing github actions that are now taken over by the unified pipeline * Removing Gitlab jobs taken over by the unified pipeline * Adding a job to download artifacts from the github build * Merging the download artifacts with dependencies from pypi `.gitlab-ci.yml` is best reviewed in its final form rather than as a diff. **How to test the change?** The changes were tested manually. CI/CD workflows are notoriously hard to test. Final products the final lib-init image was run through automated onboarding tests. `dd-trace-py` doesn't have automated tests for OCI images - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
emmettbutler
requested review from
erikayasuda,
brettlangdon,
randomanderson,
christophe-papazian and
vitor-de-araujo
September 5, 2024 15:18
christophe-papazian
approved these changes
Sep 5, 2024
christophe-papazian
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Sep 5, 2024
brettlangdon
approved these changes
Sep 6, 2024
Seems there is something missing. Probably because there have been updates to the |
Blocked on #10563 cc @erikayasuda |
Gitlab jobs can't find files on 2.9 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Converts the Gitlab workflow to use the unified pipeline.
By using the unified pipeline across all APM libraries, there is less maintenance hassle, fewer mistakes, and a more uniform creation of artifacts.
Additionally, this change creates OCI packages and lib inject images for every
dd-trace-py
build. Previously, only released versions to pypi were built and tested.The changes can be summarized as follows:
.gitlab-ci.yml
is best reviewed in its final form rather than as a diff.How to test the change?
The changes were tested manually. CI/CD workflows are notoriously hard to test. Final products the final lib-init image was run through automated onboarding tests.
dd-trace-py
doesn't have automated tests for OCI imagesChecklist
Reviewer Checklist