Skip to content

Commit

Permalink
chore(crashtracking): add python version to crashtracker tags [backpo…
Browse files Browse the repository at this point in the history
…rt 2.13] (#10733)

Backport fe5b42f from #10720 to 2.13.

During escalations it's currently difficult to find the exact Python
version relevant for a defect. This is a simple fix for that.

I'm recommending a backport because
1. The fix is simple
2. 2.11 and onward introduce crashtracker, and we're still dealing with
crashes from those versions

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: David Sanchez <[email protected]>
  • Loading branch information
github-actions[bot] and sanchda authored Oct 30, 2024
1 parent bb4e3f2 commit fa0948f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ddtrace/internal/core/crashtracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,14 @@ def start() -> bool:
if not is_available:
return False

import platform

crashtracker.set_url(crashtracker_config.debug_url or agent.get_trace_url())
crashtracker.set_service(config.service)
crashtracker.set_version(config.version)
crashtracker.set_env(config.env)
crashtracker.set_runtime_id(get_runtime_id())
crashtracker.set_runtime_version(platform.python_version())
crashtracker.set_library_version(version.get_version())
crashtracker.set_alt_stack(bool(crashtracker_config.alt_stack))
crashtracker.set_wait_for_receiver(bool(crashtracker_config.wait_for_receiver))
Expand Down

0 comments on commit fa0948f

Please sign in to comment.