Skip to content

Commit

Permalink
ci(profiling): ignore deprecated function tp_print warning [backpor…
Browse files Browse the repository at this point in the history
…t 2.20] (#12200)

Co-authored-by: Taegyun Kim <[email protected]>
  • Loading branch information
github-actions[bot] and taegyunkim authored Feb 4, 2025
1 parent 3bd50fa commit 57910a7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ add_library(${EXTENSION_NAME} SHARED ${CRASHTRACKER_CPP_SRC})
add_ddup_config(${EXTENSION_NAME})
# Cython generates code that produces errors for the following, so relax compile options
target_compile_options(${EXTENSION_NAME} PRIVATE -Wno-old-style-cast -Wno-shadow -Wno-address)
# tp_print is marked deprecated in Python 3.8, but cython still generates code using it
if("${Python3_VERSION_MINOR}" STREQUAL "8")
target_compile_options(${EXTENSION_NAME} PRIVATE -Wno-deprecated-declarations)
endif()

# cmake may mutate the name of the library (e.g., lib- and -.so for dynamic libraries). This suppresses that behavior,
# which is required to ensure all paths can be inferred correctly by setup.py.
Expand Down
4 changes: 4 additions & 0 deletions ddtrace/internal/datadog/profiling/ddup/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ add_library(${EXTENSION_NAME} SHARED ${DDUP_CPP_SRC})
add_ddup_config(${EXTENSION_NAME})
# Cython generates code that produces errors for the following, so relax compile options
target_compile_options(${EXTENSION_NAME} PRIVATE -Wno-old-style-cast -Wno-shadow -Wno-address)
# tp_print is marked deprecated in Python 3.8, but cython still generates code using it
if("${Python3_VERSION_MINOR}" STREQUAL "8")
target_compile_options(${EXTENSION_NAME} PRIVATE -Wno-deprecated-declarations)
endif()

# cmake may mutate the name of the library (e.g., lib- and -.so for dynamic libraries). This suppresses that behavior,
# which is required to ensure all paths can be inferred correctly by setup.py.
Expand Down

0 comments on commit 57910a7

Please sign in to comment.