Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] ci: add codeowners to gotestsum report (#3118) #3125

Open
wants to merge 3 commits into
base: v2-dev
Choose a base branch
from

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Jan 28, 2025

What does this PR do?

ports #3118 to v2

Contrib CODEOWNERS
image

Other CODEOWNERS
image

Motivation

Add CODEOWNERS support to v2.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@hannahkm hannahkm requested review from a team as code owners January 28, 2025 17:42
@hannahkm hannahkm marked this pull request as draft January 28, 2025 17:45
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 28, 2025

Datadog Report

Branch report: hannahkm/add-codeowners-v2
Commit report: 4c5457d
Test service: dd-trace-go

✅ 0 Failed, 4095 Passed, 64 Skipped, 2m 42.09s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-01-28 20:35:05

Comparing candidate commit f37dec0 in PR branch hannahkm/add-codeowners-v2 with baseline commit c31e444 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 0 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review January 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant