Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Extensions Macro Benchmarks #3106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jan 20, 2025

What does this PR do?

  • Add Macro Benchmarks for Service Extensions.
    This PR from Benchmarking Platform merge the changes that adds scenarios for Service Extensions into the go/go-prof-app branch.

  • It also updates the base image name to the new one that includes Envoy.

Motivation

QA feedbacks on each main commits.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 marked this pull request as ready for review January 20, 2025 15:27
@e-n-0 e-n-0 requested review from a team as code owners January 20, 2025 15:27
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: flavien/envoy/merge-brenchmarks
Commit report: b95cc90
Test service: dd-trace-go

✅ 0 Failed, 5189 Passed, 72 Skipped, 2m 31.94s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 15:49:18

Comparing candidate commit 0436ca9 in PR branch flavien/envoy/merge-brenchmarks with baseline commit 2e3193f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@@ -1,7 +1,7 @@
variables:
BENCHMARKS_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:go-go-prof-app
BENCHMARKS_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:go-go-prof-app-and-serviceextensions-0001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-n-0 How's this image maintained?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is built from the branch go/go-prof-app of the benchmarking-platform repo.
The image is only built one time (by running the ci-images CI stage).
The image can be rebuild anytime we want, if for example we want to have a newer version of Envoy.

# (using Envoy External Processing)
#

.benchmarks-serviceextensions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-n-0 What's the reason to keep a separate benchmark suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants