-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Service Extensions Macro Benchmarks #3106
base: main
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5189 Passed, 72 Skipped, 2m 31.94s Total Time |
BenchmarksBenchmark execution time: 2025-01-20 15:49:18 Comparing candidate commit 0436ca9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
@@ -1,7 +1,7 @@ | |||
variables: | |||
BENCHMARKS_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:go-go-prof-app | |||
BENCHMARKS_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:go-go-prof-app-and-serviceextensions-0001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-n-0 How's this image maintained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is built from the branch go/go-prof-app of the benchmarking-platform repo.
The image is only built one time (by running the ci-images
CI stage).
The image can be rebuild anytime we want, if for example we want to have a newer version of Envoy.
# (using Envoy External Processing) | ||
# | ||
|
||
.benchmarks-serviceextensions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-n-0 What's the reason to keep a separate benchmark suite?
What does this PR do?
Add Macro Benchmarks for Service Extensions.
This PR from Benchmarking Platform merge the changes that adds scenarios for Service Extensions into the go/go-prof-app branch.
It also updates the base image name to the new one that includes Envoy.
Motivation
QA feedbacks on each main commits.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!