Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: Support DD_DOGSTATSD_HOST env var #3084

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

mtoffl01
Copy link
Contributor

What does this PR do?

Allows use of DD_DOGSTATSD_HOST env var to specify destination of the statsd client. Takes precedence over DD_AGENT_HOST for the statsd client.

Motivation

Config Consistency: Ref.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 14, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 14, 2025

Datadog Report

Branch report: mtoff/dogstatsd-host
Commit report: 8f1b4b1
Test service: dd-trace-go

✅ 0 Failed, 5135 Passed, 70 Skipped, 2m 30.18s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-14 20:57:02

Comparing candidate commit 48adfed in PR branch mtoff/dogstatsd-host with baseline commit 471d723 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@mtoffl01 mtoffl01 marked this pull request as ready for review January 15, 2025 17:58
@mtoffl01 mtoffl01 requested review from a team as code owners January 15, 2025 17:58
@mtoffl01 mtoffl01 enabled auto-merge (squash) January 16, 2025 20:05
@mtoffl01 mtoffl01 merged commit e2c2789 into main Jan 17, 2025
160 of 161 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/dogstatsd-host branch January 17, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants