Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/IBM/sarama.v1: use an unique topic name for tests #3075

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jan 10, 2025

What does this PR do?

Use unique group ID and topic names for the IBM/sarama tests.

Motivation

IBM/sarama test are flaking: example

Particularly seeing these logs:

    consumer_group_test.go:144: Message claimed: value = test 1, timestamp = 2025-01-10 14:09:58.608 +0000 UTC, topic = gotest
    consumer_group_test.go:144: Message claimed: value = value2, timestamp = 2025-01-10 14:09:59.652 +0000 UTC, topic = gotest

The second message seems to be produced by a different kafka test, so there is a chance the failed tests are caused by this extra unexpected message from a different test.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF requested review from a team as code owners January 10, 2025 15:59
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 10, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: rarguelloF/ibm-sarama-different-topic-tests
Commit report: 5fbfaec
Test service: dd-trace-go

✅ 0 Failed, 5123 Passed, 70 Skipped, 2m 34.31s Total Time

Copy link
Contributor

@hannahkm hannahkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏🏼

@hannahkm hannahkm merged commit 27624f6 into main Jan 10, 2025
161 of 162 checks passed
@hannahkm hannahkm deleted the rarguelloF/ibm-sarama-different-topic-tests branch January 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants