-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/telemetry: revamp #2996
base: main
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2025-01-31 16:50:34 Comparing candidate commit 681eae1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
bb195d0
to
58aaf77
Compare
Datadog ReportBranch report: ❌ 4 Failed (0 Known Flaky), 5225 Passed, 72 Skipped, 2m 27.22s Total Time ❌ Failed Tests (4)
|
3624406
to
54a315e
Compare
71bf34b
to
6dad2a3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 5295 Passed, 72 Skipped, 2m 35.12s Total Time |
Signed-off-by: Eliott Bouhana <[email protected]> wip Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
centralize all http concerns in the writer struct such as: * Reusing the same top-level structures when possible * encoding properly in json the payload * separating the low level http writing from some higher level things we will concerns ourselves about in the telemetry client itself * Centralizing a lot of the static data the telemtry client is supposed to send on every request Signed-off-by: Eliott Bouhana <[email protected]>
…nge payloads Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
… the Size() method on data sources. Put back support for the payloadQueue in case Flush calls are failing Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
…the TelemetryLogger and replace it with a simple Log function Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
…en be used as telemetry metrics Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
…pper over sync.Map + added new metrics data source + added support for count metrics end 2 end Signed-off-by: Eliott Bouhana <[email protected]>
…moved the types package and added aliases for both types in the newtelemetry packag. And finished implementing gauge and rate metrics Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
…internal metrics support Signed-off-by: Eliott Bouhana <[email protected]>
b29c203
to
05b010c
Compare
Signed-off-by: Eliott Bouhana <[email protected]>
…queue ground up Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
…RegisterAppConfigs Signed-off-by: Eliott Bouhana <[email protected]>
95f5cd1
to
29fc678
Compare
…nsition from the previous telemetry client Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
51286ca
to
8bc28bc
Compare
Signed-off-by: Eliott Bouhana <[email protected]>
What does this PR do?
This PR rebuilds fron scratch the current instrumentation telemetry client. More informations here:
https://docs.google.com/document/d/1C3xoTZHQZNQ-Jr1w5mMThIkpHNW_4qKRf-J5CNi7G-k/edit?pli=1&tab=t.0#heading=h.88xvn2cvs9dt
Reviewer's Checklist
Unsure? Have a question? Request a review!