contrib/cloud.google.com/go/pubsub.v1: split tracing code #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… separate package
github-actions
bot
added
the
apm:ecosystem
BenchmarksBenchmark execution time: 2024-09-11 15:11:47 Comparing candidate commit ba11596 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
nsrip-dd
pushed a commit
that referenced
this pull request
Sep 12, 2024
github-merge-queue bot
pushed a commit
to DataDog/orchestrion
that referenced
this pull request
Sep 23, 2024
Adds support for instrumenting `cloud.google.com/go/pubsub` Requires DataDog/dd-trace-go#2852 --------- Co-authored-by: Romain Marcadier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split tracing logic into a separate package that does not import
cloud.google.com/go/pubsubso it can be used in orchestrion.Motivation
orchestrion cannot reuse the pubsub contrib package as it is right now because it would case an import cycle. Creating a separate package allows us to reuse this logic.
Reviewer's Checklist
Unsure? Have a question? Request a review!