Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) tests: Ignore new metric #160

Merged
merged 4 commits into from
Feb 12, 2024
Merged

(fix) tests: Ignore new metric #160

merged 4 commits into from
Feb 12, 2024

Conversation

tabgok
Copy link
Contributor

@tabgok tabgok commented Feb 12, 2024

A new metric, metrics._dd.tracer_kr, was added to dd-trace-py causing snapshot tests tofail. This metric is now added to the list of ignored snapshot fields.

A new metric, metrics._dd.tracer_kr, was added to `dd-trace-py` causing
snapshot tests tofail.  This metric is now added to the list of ignored
snapshot fields.
@tabgok tabgok self-assigned this Feb 12, 2024
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabgok tabgok requested a review from Kyle-Verhoog February 12, 2024 21:36
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ my bad, I thought this PR was updating the default ignores for the whole test agent and not just in the tests. I'll make the change to revert the release note.

@Kyle-Verhoog Kyle-Verhoog merged commit e0eb48d into master Feb 12, 2024
14 of 15 checks passed
@Kyle-Verhoog Kyle-Verhoog deleted the teague.bick/fix-tests branch February 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants