Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): update session logic #159

Merged
merged 1 commit into from
Feb 13, 2024
Merged

(feat): update session logic #159

merged 1 commit into from
Feb 13, 2024

Conversation

tabgok
Copy link
Contributor

@tabgok tabgok commented Feb 12, 2024

Does the following:

  • Clearing a session now clears traces only, instead of also deleting the session
  • Requesting traces for a esssion will return a 404 Session Not found if no traces or session match a non-None session token
  • Sessions now return session-less requests only up to the latest session marker

Kyle-Verhoog
Kyle-Verhoog reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate the 3 changes into 3 separate PRs? This would help make the changes more reviewable and make sure that we're testing each.

Just two questions for now pending the answer to the above question

@tabgok tabgok force-pushed the teague.bick/session-logic branch from 25161a8 to 2f8aa23 Compare February 12, 2024 21:26
@tabgok tabgok changed the title Update session logic (featu): update session logic Feb 12, 2024
@tabgok tabgok changed the title (featu): update session logic (feat): update session logic Feb 12, 2024
Kyle-Verhoog
Kyle-Verhoog reviewed Feb 12, 2024
View reviewed changes
@tabgok tabgok force-pushed the teague.bick/session-logic branch from c0aefb2 to a290aee Compare February 12, 2024 23:34
@tabgok tabgok requested a review from Kyle-Verhoog February 13, 2024 17:39
@tabgok tabgok self-assigned this Feb 13, 2024
@tabgok tabgok requested a review from Kyle-Verhoog February 13, 2024 19:21
Kyle-Verhoog
Kyle-Verhoog reviewed Feb 13, 2024
View reviewed changes
Kyle-Verhoog
Kyle-Verhoog reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one, i promise!

@tabgok
(feat) update logic used to retrieve session traces
815476e 
Does the following:

- Clearing a session now clears traces only, instead of also deleting the session
- Requesting traces for a esssion will return a 404 Session Not found if no traces or session match a non-None session token
- Sessions now return session-less requests only up to the latest session marker
@tabgok tabgok force-pushed the teague.bick/session-logic branch from 6ebcf65 to 815476e Compare February 13, 2024 20:51
Kyle-Verhoog
Kyle-Verhoog approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks @tabgok!

@Kyle-Verhoog Kyle-Verhoog merged commit 2939910 into master Feb 13, 2024
11 checks passed
@Kyle-Verhoog Kyle-Verhoog deleted the teague.bick/session-logic branch February 13, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

Assignees

@tabgok tabgok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabgok @Kyle-Verhoog