[do not review][OTEL-2371] invesigate gopstuil

[songy23]

No description provided.

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
1	148	0	0

Updated: .gitlab/deploy_containers/deploy_containers_a7.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
2	4	10	0

ℹ️ Diff available in the job log.

[github-actions]

⚠️🚨 Warning, this pull request increases the binary size of serverless extension by 807912 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 8ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

These dependencies were added to the serverless extension by this pull request:

go.opentelemetry.io/collector/pdata/pprofile
go.opentelemetry.io/contrib/config
go.opentelemetry.io/collector/pdata/pcommon

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[github-actions]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 40f0be0 and efc15d9.

tl;dr

Use these benchmarks as an insight tool during development.

1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            84.16µ ± 3%   84.58µ ± 3%       ~ (p=0.853 n=10)
api-gateway-kong-appsec.json                       66.35µ ± 1%   66.49µ ± 1%       ~ (p=0.644 n=10)
api-gateway-kong.json                              64.87µ ± 2%   64.64µ ± 2%       ~ (p=0.579 n=10)
api-gateway-non-proxy-async.json                   104.0µ ± 2%   102.8µ ± 2%       ~ (p=0.436 n=10)
api-gateway-non-proxy.json                         106.5µ ± 1%   103.4µ ± 2%  -2.93% (p=0.000 n=10)
api-gateway-websocket-connect.json                 69.89µ ± 2%   69.70µ ± 1%       ~ (p=0.912 n=10)
api-gateway-websocket-default.json                 64.23µ ± 3%   63.02µ ± 2%       ~ (p=0.247 n=10)
api-gateway-websocket-disconnect.json              63.30µ ± 1%   63.44µ ± 2%       ~ (p=0.481 n=10)
api-gateway.json                                   115.5µ ± 1%   116.2µ ± 1%  +0.61% (p=0.043 n=10)
application-load-balancer.json                     64.51µ ± 2%   64.81µ ± 2%       ~ (p=0.796 n=10)
cloudfront.json                                    47.76µ ± 1%   47.58µ ± 1%       ~ (p=0.529 n=10)
cloudwatch-events.json                             39.52µ ± 1%   39.21µ ± 1%       ~ (p=0.075 n=10)
cloudwatch-logs.json                               67.50µ ± 2%   66.69µ ± 2%       ~ (p=0.247 n=10)
custom.json                                        32.51µ ± 2%   31.90µ ± 2%  -1.89% (p=0.001 n=10)
dynamodb.json                                      95.11µ ± 1%   93.99µ ± 1%  -1.18% (p=0.001 n=10)
empty.json                                         30.47µ ± 2%   29.89µ ± 1%  -1.92% (p=0.007 n=10)
eventbridge-custom.json                            48.27µ ± 2%   47.88µ ± 1%       ~ (p=0.063 n=10)
eventbridge-no-bus.json                            47.71µ ± 2%   47.01µ ± 1%       ~ (p=0.063 n=10)
eventbridge-no-timestamp.json                      47.75µ ± 2%   46.56µ ± 1%  -2.50% (p=0.000 n=10)
eventbridgesns.json                                64.57µ ± 1%   63.35µ ± 2%  -1.88% (p=0.015 n=10)
eventbridgesqs.json                                72.74µ ± 2%   71.54µ ± 2%       ~ (p=0.105 n=10)
http-api.json                                      73.68µ ± 2%   71.93µ ± 2%  -2.37% (p=0.004 n=10)
kinesis-batch.json                                 72.73µ ± 1%   70.91µ ± 2%  -2.51% (p=0.007 n=10)
kinesis.json                                       56.04µ ± 1%   55.02µ ± 2%  -1.81% (p=0.023 n=10)
s3.json                                            61.54µ ± 1%   60.69µ ± 3%       ~ (p=0.089 n=10)
sns-batch.json                                     93.63µ ± 1%   92.48µ ± 2%  -1.23% (p=0.009 n=10)
sns.json                                           69.39µ ± 2%   69.58µ ± 3%       ~ (p=0.436 n=10)
snssqs.json                                        121.0µ ± 2%   119.7µ ± 1%       ~ (p=0.315 n=10)
snssqs_no_dd_context.json                          108.2µ ± 1%   107.3µ ± 1%       ~ (p=0.123 n=10)
sqs-aws-header.json                                61.57µ ± 2%   60.74µ ± 3%       ~ (p=0.190 n=10)
sqs-batch.json                                     97.54µ ± 2%   97.28µ ± 2%       ~ (p=0.529 n=10)
sqs.json                                           75.13µ ± 2%   74.54µ ± 2%       ~ (p=0.105 n=10)
sqs_no_dd_context.json                             69.36µ ± 4%   68.69µ ± 2%       ~ (p=0.315 n=10)
stepfunction.json                                  45.93µ ± 3%   45.60µ ± 4%       ~ (p=0.123 n=10)
geomean                                            66.95µ        66.25µ       -1.04%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.27Ki ± 0%   37.33Ki ± 0%  +0.17% (p=0.000 n=10)
api-gateway-kong-appsec.json                      26.93Ki ± 0%   26.94Ki ± 0%       ~ (p=0.565 n=10)
api-gateway-kong.json                             24.43Ki ± 0%   24.43Ki ± 0%       ~ (p=0.669 n=10)
api-gateway-non-proxy-async.json                  48.08Ki ± 0%   48.13Ki ± 0%  +0.11% (p=0.000 n=10)
api-gateway-non-proxy.json                        47.30Ki ± 0%   47.35Ki ± 0%  +0.11% (p=0.000 n=10)
api-gateway-websocket-connect.json                25.51Ki ± 0%   25.53Ki ± 0%  +0.11% (p=0.000 n=10)
api-gateway-websocket-default.json                21.42Ki ± 0%   21.45Ki ± 0%  +0.13% (p=0.000 n=10)
api-gateway-websocket-disconnect.json             21.19Ki ± 0%   21.23Ki ± 0%  +0.15% (p=0.000 n=10)
api-gateway.json                                  49.60Ki ± 0%   49.61Ki ± 0%       ~ (p=0.271 n=10)
application-load-balancer.json                    22.38Ki ± 0%   23.32Ki ± 0%  +4.22% (p=0.000 n=10)
cloudfront.json                                   17.67Ki ± 0%   17.69Ki ± 0%  +0.11% (p=0.001 n=10)
cloudwatch-events.json                            11.71Ki ± 0%   11.74Ki ± 0%  +0.25% (p=0.000 n=10)
cloudwatch-logs.json                              53.40Ki ± 0%   53.39Ki ± 0%       ~ (p=0.383 n=10)
custom.json                                       9.750Ki ± 0%   9.772Ki ± 0%  +0.23% (p=0.001 n=10)
dynamodb.json                                     40.79Ki ± 0%   40.82Ki ± 0%  +0.07% (p=0.012 n=10)
empty.json                                        9.328Ki ± 0%   9.343Ki ± 0%       ~ (p=0.066 n=10)
eventbridge-custom.json                           15.03Ki ± 0%   15.04Ki ± 0%       ~ (p=0.469 n=10)
eventbridge-no-bus.json                           14.02Ki ± 0%   14.02Ki ± 0%       ~ (p=0.516 n=10)
eventbridge-no-timestamp.json                     14.05Ki ± 0%   14.02Ki ± 0%       ~ (p=0.165 n=10)
eventbridgesns.json                               20.99Ki ± 0%   21.01Ki ± 0%       ~ (p=0.670 n=10)
eventbridgesqs.json                               25.17Ki ± 0%   25.19Ki ± 0%       ~ (p=0.063 n=10)
http-api.json                                     23.91Ki ± 0%   23.97Ki ± 0%  +0.29% (p=0.002 n=10)
kinesis-batch.json                                27.11Ki ± 0%   27.15Ki ± 0%  +0.14% (p=0.043 n=10)
kinesis.json                                      17.93Ki ± 0%   17.96Ki ± 1%       ~ (p=0.838 n=10)
s3.json                                           20.47Ki ± 0%   20.49Ki ± 1%       ~ (p=0.066 n=10)
sns-batch.json                                    39.96Ki ± 0%   39.95Ki ± 1%       ~ (p=0.739 n=10)
sns.json                                          25.22Ki ± 0%   25.22Ki ± 1%       ~ (p=0.853 n=10)
snssqs.json                                       53.95Ki ± 0%   53.92Ki ± 0%       ~ (p=0.753 n=10)
snssqs_no_dd_context.json                         47.52Ki ± 0%   47.65Ki ± 0%  +0.27% (p=0.003 n=10)
sqs-aws-header.json                               19.48Ki ± 1%   19.42Ki ± 1%       ~ (p=0.393 n=10)
sqs-batch.json                                    42.36Ki ± 1%   42.29Ki ± 1%       ~ (p=0.325 n=10)
sqs.json                                          26.38Ki ± 1%   26.25Ki ± 1%       ~ (p=0.218 n=10)
sqs_no_dd_context.json                            21.88Ki ± 1%   21.91Ki ± 1%       ~ (p=0.631 n=10)
stepfunction.json                                 14.34Ki ± 1%   14.30Ki ± 1%       ~ (p=0.617 n=10)
geomean                                           24.59Ki        24.63Ki       +0.17%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.5 ± 0%   629.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy-async.json                    726.0 ± 0%   725.5 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway.json                                    791.0 ± 0%   791.0 ± 0%       ~ (p=0.195 n=10)
application-load-balancer.json                      352.0 ± 0%   353.0 ± 0%  +0.28% (p=0.000 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-logs.json                                216.0 ± 0%   216.0 ± 0%       ~ (p=1.000 n=10)
custom.json                                         168.5 ± 0%   169.0 ± 0%       ~ (p=0.141 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=1.000 n=10)
empty.json                                          160.0 ± 0%   160.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             266.0 ± 0%   267.0 ± 0%       ~ (p=0.656 n=10)
eventbridge-no-bus.json                             258.0 ± 0%   258.0 ± 0%       ~ (p=1.000 n=10)
eventbridge-no-timestamp.json                       258.0 ± 0%   258.0 ± 0%       ~ (p=0.070 n=10)
eventbridgesns.json                                 327.0 ± 0%   326.5 ± 0%       ~ (p=0.076 n=10)
eventbridgesqs.json                                 367.0 ± 0%   367.0 ± 0%       ~ (p=0.706 n=10)
http-api.json                                       435.0 ± 0%   435.0 ± 0%       ~ (p=0.720 n=10)
kinesis-batch.json                                  392.0 ± 0%   392.0 ± 0%       ~ (p=0.712 n=10)
kinesis.json                                        286.5 ± 1%   287.0 ± 1%       ~ (p=0.638 n=10)
s3.json                                             359.5 ± 0%   359.0 ± 1%       ~ (p=0.657 n=10)
sns-batch.json                                      479.0 ± 0%   479.0 ± 1%       ~ (p=0.690 n=10)
sns.json                                            347.5 ± 0%   347.5 ± 1%       ~ (p=0.844 n=10)
snssqs.json                                         480.0 ± 0%   479.0 ± 0%       ~ (p=0.097 n=10)
snssqs_no_dd_context.json                           436.0 ± 0%   437.5 ± 0%       ~ (p=0.113 n=10)
sqs-aws-header.json                                 287.0 ± 1%   286.0 ± 1%       ~ (p=0.413 n=10)
sqs-batch.json                                      517.5 ± 1%   516.5 ± 1%       ~ (p=0.404 n=10)
sqs.json                                            366.5 ± 1%   364.5 ± 1%       ~ (p=0.126 n=10)
sqs_no_dd_context.json                              350.0 ± 1%   350.0 ± 1%       ~ (p=0.895 n=10)
stepfunction.json                                   238.5 ± 1%   238.0 ± 0%       ~ (p=0.095 n=10)
geomean                                             367.6        367.5       -0.01%
¹ all samples are equal

[cit-pr-commenter]

Go Package Import Differences

This comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output.