Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "assert detected language in agent workloadmeta in e2e test" #33357

Conversation

adel121
Copy link
Contributor

@adel121 adel121 commented Jan 24, 2025

This reverts commit 6b75af2.

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@adel121 adel121 requested review from a team as code owners January 24, 2025 14:38
@adel121 adel121 added the qa/done QA done before merge and regressions are covered by tests label Jan 24, 2025
@adel121 adel121 added this to the 7.64.0 milestone Jan 24, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 24, 2025
@adel121 adel121 added changelog/no-changelog and removed short review PR is simple enough to be reviewed quickly labels Jan 24, 2025
@adel121 adel121 marked this pull request as draft January 24, 2025 14:42
@adel121 adel121 force-pushed the adelhajhassan/revert_agent_cli_assertion_e2e_for_language_detection branch from 9aace88 to a7aeed0 Compare January 24, 2025 14:48
@adel121 adel121 marked this pull request as ready for review January 24, 2025 14:49
@adel121
Copy link
Contributor Author

adel121 commented Jan 24, 2025

/merge

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 24, 2025
@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 14:49:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-24 17:56:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2025-01-24 18:31:28 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Uncompressed package size comparison

Comparison with ancestor d933e4b1ed489180712408f0b17ac61639d1341e

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 928.87MB 928.87MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 938.61MB 938.61MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.61MB 938.61MB 0.50MB
datadog-agent-arm64-deb 0.00MB 916.06MB 916.06MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.78MB 925.78MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.99MB 58.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.07MB 59.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.48MB 56.48MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.87MB 477.87MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

[Fast Unit Tests Report]

On pipeline 53941314 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53941314 --os-family=ubuntu

Note: This applies to commit 8ead854

Copy link

cit-pr-commenter bot commented Jan 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e50bd08c-b8e9-435c-a06c-30895a5d3c3e

Baseline: d933e4b
Comparison: 8ead854
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.92 [+0.87, +0.97] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.78 [-2.28, +3.85] 1 Logs
quality_gate_idle_all_features memory utilization +0.57 [+0.53, +0.60] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.15 [-0.63, +0.93] 1 Logs
file_tree memory utilization +0.08 [+0.03, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.83, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.73, +0.73] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.66, +0.60] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.92, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.93, +0.84] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.70, +0.24] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.93 [-1.00, -0.86] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.14 [-2.01, -0.28] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -1.79 [-2.59, -1.00] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@adel121
Copy link
Contributor Author

adel121 commented Jan 24, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-24 18:00:14 UTC ❌ MergeQueue

PR already in the queue with status in_progress

@dd-mergequeue dd-mergequeue bot merged commit d90e7fa into main Jan 24, 2025
215 of 223 checks passed
@dd-mergequeue dd-mergequeue bot deleted the adelhajhassan/revert_agent_cli_assertion_e2e_for_language_detection branch January 24, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants